fix: corrected anchor tags href in Playground sidebar #859
Conversation
Santhoshmani1
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Santhoshmani1
changed the title
Santhoshmani1
changed the title
|
This doesn't appear to fix the problem correctly. You're adding a new anchor instead of fixing the existing anchor with the format: |
|
@Santhoshmani1 please have a look at comment from @BTOdell |
|
Async.API.playground.links.corrected.mp4I have changed the href attribute of sidebar links and added the id attribute to match in the operations. It's working correctly as expected and fixes the problem. |
| @@ -360,7 +360,7 @@ const OperationsList: React.FunctionComponent = () => { | |||
| interface OperationItemProps { | |||
| channelName: string; | |||
| summary: string; | |||
| kind: 'publish' | 'subscribe'; | |||
| kind: 'subscribe' | 'publish'; | |||
|
@Santhoshmani1, I just wanted to say thank you for the contribution 🚀 |
|
@Santhoshmani1 you do not want to continue with this one? |
Description
Changes proposed in this pull request:
Related issue(s)
Fixes