Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected anchor tags href in Playground sidebar #859

Closed
wants to merge 2 commits into from
Closed

fix: corrected anchor tags href in Playground sidebar #859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d6545
fix: corrected anchor tags href in Playground sidebar
Santhoshmani1 Dec 12, 2023
06bd136
Merge branch 'master' into playground-navbar-anchors-fix
Santhoshmani1 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/src/containers/Operations/Operation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ export const OperationInfo: React.FunctionComponent<Props> = props => {
<span
className={`font-mono border uppercase p-1 rounded mr-2 ${borderColor}`}
title={type}
id={channelName}
>
{typeLabel}
</span>{' '}
Expand Down
4 changes: 2 additions & 2 deletions library/src/containers/Sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ const OperationsList: React.FunctionComponent = () => {
interface OperationItemProps {
channelName: string;
summary: string;
kind: 'publish' | 'subscribe';
kind: 'subscribe' | 'publish';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change needed?

}

const OperationItem: React.FunctionComponent<OperationItemProps> = ({
Expand All @@ -383,7 +383,7 @@ const OperationItem: React.FunctionComponent<OperationItemProps> = ({
<li>
<a
className="flex no-underline text-gray-700 mb-2 hover:text-gray-900"
href={`#operation-${kind}-${channelName}`}
href={'#' + channelName}
Santhoshmani1 marked this conversation as resolved.
Show resolved Hide resolved
onClick={() => setShowSidebar(false)}
>
<span
Expand Down
Loading