-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize dockerfile #1281
perf: optimize dockerfile #1281
Conversation
|
This reverts commit 75367d2.
By mistake I committed this file
try to fix the maintainability issue
1. Ensuring that the ARG is defined in the correct scope. 2. Protecting against potential issues with variable expansion.
made changes which was suggested in the sonarcloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove cli.js
changes
Quality Gate passedIssues Measures |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cli.js
is still showing up in the list of modified files
Pls. have a look on the comment #1283 (comment) to fix this |
Description
In this PR I worked on this issues
Attaching updated test results file after the changes which I made test-results.txt
Results
I solved this issue after reading sonarcloud suggestion and how it work
Related issue(s)