Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize dockerfile #1281

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/generator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
ARG ASYNCAPI_GENERATOR_VERSION=1.10.9

FROM node:18-alpine

WORKDIR /app
Expand All @@ -8,14 +6,16 @@ WORKDIR /app
ENV PUPPETEER_EXECUTABLE_PATH /usr/bin/chromium-browser
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true

# Include the ARG instruction in this build stage
ARG ASYNCAPI_GENERATOR_VERSION=1.10.9

# Since 0.30.0 release Git is supported and required as a dependency
# Since 0.14.0 release of html-template chromium is needed for pdf generation.
# More custom packages for specific template should not be added to this dockerfile. Instead, we should come up with some extensibility solution.
RUN apk --update add git chromium && \
rm -rf /var/lib/apt/lists/* && \
rm /var/cache/apk/*

# Installing latest released npm package
RUN npm install -g @asyncapi/generator@$ASYNCAPI_GENERATOR_VERSION
# The --no-cache prevents from caching of the package index which saves space by not storing the APK cache files.
# Install dependencies and AsyncAPI Generator in a single RUN command
RUN apk --no-cache add git chromium && \
rm -rf /var/cache/apk/* && \
npm install -g --ignore-scripts "@asyncapi/generator@${ASYNCAPI_GENERATOR_VERSION}"

ENTRYPOINT [ "ag" ]
Empty file modified apps/generator/cli.js
100755 → 100644
derberg marked this conversation as resolved.
Show resolved Hide resolved
Empty file.
Loading