Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify variable initialization #1283

Conversation

thebedigupta
Copy link
Contributor

@thebedigupta thebedigupta commented Oct 4, 2024

Description

In this PR I try to solve this issue

I am also attching test files captured results test-results.txt

  • unnecessary initialization

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 2ec4151

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

I try to undo the changes that my code formatter was done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete this file, Please get it back

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove changes to cli.js and as usual make sure you do not use any autoformatter

@thebedigupta
Copy link
Contributor Author

remove changes to cli.js and as usual make sure you do not use any autoformatter

done

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli.js is still showing up in the list of modified files

@thebedigupta
Copy link
Contributor Author

thebedigupta commented Oct 10, 2024

cli.js is still showing up in the list of modified files

let me create another PR for this issue

@DhairyaMajmudar
Copy link
Contributor

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps:

-> Copy and paste the content of the original cli.js file to your empty file.
-> Commit and push the changes to your PR

@thebedigupta
Copy link
Contributor Author

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps:

-> Copy and paste the content of the original cli.js file to your empty file. -> Commit and push the changes to your PR

Oh it's that much easy ok I will do it and thank you for your suggestion

@thebedigupta thebedigupta force-pushed the chore/simplify-variable-initialization branch from 74875d1 to 3a53813 Compare October 10, 2024 10:06
Copy link

@thebedigupta
Copy link
Contributor Author

thebedigupta commented Oct 10, 2024

let me create another PR for this issue

@thebedigupta no need to open a separate PR, by mistake, you've pushed the empty cli.js file since the content in the file is removed that's why it's showing in the list of modified files. To fix this you can follow the following steps:
-> Copy and paste the content of the original cli.js file to your empty file. -> Commit and push the changes to your PR

Oh it's that much easy ok I will do it and thank you for your suggestion

I tried it but it was not working i don't know why anyway let me create another PR for removing these cli.js file issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants