-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overall structure and reliability of the function #1288
fix: overall structure and reliability of the function #1288
Conversation
I try to undo the changes that my code formatter was done
|
These are not necessary changes that I make in this PR It was just a part of confusion that I make because this was the first time when I am contributing to any open source project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there are so many changes in this file, can you please explain?
why function is now sync? wasn't it enough to just remove async from promise?
…roach sorry for over complementing things you are right this was the straight-forward approach for solving this issue
Changes made: - Removed 'async' keyword from the Promise executor function in registerLocalHooks - No other modifications were made to preserve the original functionality
sorry for overcomplicating the work you are right removing async is the straight-forward approach |
remove unwanted comments and add space
Quality Gate passedIssues Measures |
Description
In this PR I worked on that issue
This is the test results that I performed test-results.txt
Resolve