Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overall structure and reliability of the function #1288

Closed
wants to merge 10 commits into from
+1 −1
Closed

fix: overall structure and reliability of the function #1288

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a31d964
refactor: improve generate function structure
thebedigupta Oct 3, 2024
a2cade3
Update cli.js
thebedigupta Oct 5, 2024
b662524
This refactored version should work more reliably and be easier to ma…
thebedigupta Oct 7, 2024
e8a8339
remove cli file that was changed because of code formatters
thebedigupta Oct 7, 2024
8e8924d
Merge branch 'master' into fix/register-hooks-function
thebedigupta Oct 8, 2024
954d70e
Merge branch 'master' into fix/register-hooks-function
thebedigupta Oct 8, 2024
ad5669e
Merge branch 'master' into fix/register-hooks-function
thebedigupta Oct 9, 2024
0579c0a
removed the async keyword from the Promise executor is the direct app…
thebedigupta Oct 9, 2024
c83011d
Remove async keyword from Promise executor in registerLocalHooks
thebedigupta Oct 9, 2024
cda6448
remove unnecessary comment
thebedigupta Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/generator/lib/hooksRegistry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports.registerHooks = async (hooks, templateConfig, templateDir, hooksD
* @param {String} hooksDir Directory where local hooks are located.
*/
async function registerLocalHooks(hooks, templateDir, hooksDir) {
return new Promise(async (resolve, reject) => {
return new Promise((resolve, reject) => {
const localHooks = path.resolve(templateDir, hooksDir);

if (!await exists(localHooks)) return resolve(hooks);
Expand Down
Loading