feat: add request/reply support #551
Conversation
KhudaDad414
requested review from
fmvilas and
asyncapi-bot-eve
as code owners
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
| SlackEventStream: | ||
| servers: | ||
| - $ref: "#/servers/Slack_WebSocket" | ||
| address: /link/?ticket={ticket}&app_id={app_id} |
There was a problem hiding this comment.
just remember that these should go through websocket binding query field - but of course if that is not supported, parameters are good temporary solution, although in future address should be validated by parser, if not yet
There was a problem hiding this comment.
Will update it to use the bindings.
| reply: | ||
| channel: | ||
| $ref: "#/channels/SlackEventStream" |
There was a problem hiding this comment.
this feels weird, as your app is reaction listener, and I bet slack websocket server that you listen to do not expect any reply from the app that you're creating. So you receive stream and that is it
There was a problem hiding this comment.
It actually needs a reply. if slack doesn't receive a confirmation it will resend the message multiple times.
https://api.slack.com/apis/connections/socket#acknowledge
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Pull Request Test Coverage Report for Build 6930343277Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
resolves #550
resolves #544
checklist: