Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling effect on sidebar #1665

Closed
wants to merge 2 commits into from
Closed

Scrolling effect on sidebar #1665

wants to merge 2 commits into from

Conversation

anj20
Copy link

@anj20 anj20 commented May 13, 2023

Description
The sidebar was no scrolling on clicking the the required button

Related issue(s)
Issue#1582

@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dd4ff8c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/645f676c60006f00083fd252
😎 Deploy Preview https://deploy-preview-1665--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "Scrolling effect on sidebar". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1665--asyncapi-website.netlify.app/

@anj20 anj20 mentioned this pull request May 13, 2023
Copy link
Contributor

@Savio629 Savio629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unintended changes made in this pr.
Also the changes aren't working as intended.
Do look into it @anj20 🤔

@Savio629
Copy link
Contributor

Also follow the conventional commits specifications ->
fix : scrolling effect on sidebar

@akshatnema
Copy link
Member

@anj20 I'm closing this PR as I got #1668 more accurate than this one to resolve the issue. Thanks for devoting time to resolving this issue. Kindly look into other issues too

@akshatnema akshatnema closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants