Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated elements with equivalent up-to-date items in at_commons_flutter #850

Merged
merged 1 commit into from
May 23, 2024

Conversation

srieteja
Copy link
Contributor

Closes #842

- What I did

  • Replaced deprecated elements inat_commons_flutter's example app with up-to-date design elements

- How I did it

  • BackgroundColor in MaterialApp() was previously deprecated and now removed. The latest version's equivalent of BackgroundColor is called 'surface' which is now used in the examples.

- How to verify it

  • Static analysis should pass. Also, requires manual testing to ensure design elements are not broken

- Description for the changelog

fix: replace deprecated elements with equivalent up-to-date items in at_commons_flutter

@cpswan
Copy link
Member

cpswan commented May 22, 2024

@srieteja have you done the manual testing, or does that need somebody else to step in?

@srieteja
Copy link
Contributor Author

@cpswan I've just setup my emulators. Will be doing the testing now

@cpswan
Copy link
Member

cpswan commented May 22, 2024

@CurtlyCritchlow 👀 can you please sanity check this (manual tests to ensure layout isn't broken)

@srieteja
Copy link
Contributor Author

I've completed the manual testing for this one. I'm not sure if this can be merged yet. We can proceed with one of the following actions:

  1. We merge this since all the stable static analyses are passing (or)
  2. We wait for this merge until Clear up info messages from flutter analyze #847 is closed (which would ensure all the beta channel static analyses pass too)

@cpswan need your input on this.

@cpswan cpswan merged commit c930329 into trunk May 23, 2024
19 of 31 checks passed
@cpswan cpswan deleted the fix_deprecations_commons_flutter branch May 23, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter analyze failing on at_common_flutter due to deprecation
2 participants