Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: Add bandwidth limit case #5234

Merged
merged 1 commit into from
Dec 7, 2023
Merged

migration: Add bandwidth limit case #5234

merged 1 commit into from
Dec 7, 2023

Conversation

cliping
Copy link
Contributor

@cliping cliping commented Oct 26, 2023

VIRT-297906 - VM live migration with copy storage - bandwidth limit

@cliping
Copy link
Contributor Author

cliping commented Oct 26, 2023 •
edited
Loading

Test result:

Due to a bug, some cases fail.

(1/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.bandwidth.p2p: PASS (686.35 s)
(2/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.bandwidth.non_p2p: PASS (680.69 s)
(3/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.setspeed_before_migration.p2p: PASS (681.77 s)
(4/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.setspeed_before_migration.non_p2p: PASS (681.80 s)
(5/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.setspeed_during_migration.p2p: FAIL: Check bandwidth failed. (515.73 s)
(6/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_all.setspeed_during_migration.non_p2p: FAIL: Check bandwidth failed. (516.03 s)

(1/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.bandwidth.p2p: PASS (246.45 s)
(2/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.bandwidth.non_p2p: PASS (245.73 s)
(3/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.setspeed_before_migration.p2p: PASS (253.00 s)
(4/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.setspeed_before_migration.non_p2p: PASS (245.99 s)
(5/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.setspeed_during_migration.p2p: FAIL: Check bandwidth failed. (227.48 s)
(6/6) type_specific.io-github-autotest-libvirt.migration_with_copy_storage.migration_bandwidth_limit.copy_storage_inc.setspeed_during_migration.non_p2p: FAIL: Check bandwidth failed. (223.42 s)

@cliping
Copy link
Contributor Author

cliping commented Oct 30, 2023 •
edited
Loading

Depend on:
avocado-framework/avocado-vt#3789
avocado-framework/avocado-vt#3810

@cliping cliping mentioned this pull request Oct 30, 2023
Merged
Yingshun
Yingshun reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

provider/migration/migration_base.py Outdated
@@ -726,3 +727,16 @@ def get_vm_serial_session_on_dest(params):
vm_session = migration_obj.vm.wait_for_serial_login(timeout=120)
params.update({"vm_session": vm_session})
migration_obj.vm.connect_uri = backup_uri


def check_bandwidth_by_blockjob(params):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this function to a blockjob related module? And rather than limiting blockjobs to a function of checking bandwidth, the bandwidth option could be made flexible. what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@Yingshun Yingshun added the depend on The PR has dependency on other PRs label Nov 2, 2023
@cliping cliping force-pushed the bandwidth-limit branch 2 times, most recently from 6e82a29 to 9b21685 Compare December 5, 2023 14:33
@cliping cliping mentioned this pull request Dec 6, 2023
Merged
@cliping
migration: Add bandwidth limit case
62bfc21 
VIRT-297906 - VM live migration with copy storage - bandwidth limit

Signed-off-by: lcheng <[email protected]>
@chloerh chloerh merged commit 0d6fed5 into autotest:master Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun approved these changes

@chloerh chloerh chloerh approved these changes

Assignees
No one assigned
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cliping @chloerh @Yingshun