Update event timeout for copy storage migration #3789
Conversation
|
Test result in autotest/tp-libvirt#5234. |
virttest/migration.py
Outdated
| if not wait_for_event_timeout: | ||
| wait_for_event_timeout = '30' |
There was a problem hiding this comment.
Can you plz explain these 2 lines?
There was a problem hiding this comment.
Seems equal with wait_for_event_timeout = one_func.get('wait_for_event_timeout', '30')
There was a problem hiding this comment.
We can use the get() method of a dict object and return a default value if a specific key doesn't exist. If the key exists and it's None, it'll be returned.
For example,
one_func = {'before_pause': 'yes', 'need_sleep_time': '5', 'wait_for_event_timeout': None}
one_func.get('wait_for_event_timeout', '30')
one_func.get('non_exist', '30')
'30'
There was a problem hiding this comment.
Ok, so will you merge these 2 lines to 'wait_for_event_timeout = one_func.get('wait_for_event_timeout')' to make it simple?
BTW， is this 'timeout' value paired with 'after_event'? If yes, can we highlight 'after_event' in it's name?
cliping
force-pushed
the
update-timeout
branch
from
7f22176 to
25b6c13
Compare
cliping
force-pushed
the
update-timeout
branch
from
25b6c13 to
2790829
Compare
cliping
force-pushed
the
update-timeout
branch
2 times, most recently
from
b347565 to
a03b41a
Compare
It takes longer to get the desired event in copy storage migration. So update event timeout. Signed-off-by: lcheng <[email protected]>
cliping
force-pushed
the
update-timeout
branch
from
a03b41a to
e400b0c
Compare
It takes longer to get the desired event in copy storage migration. So update event timeout.