refactor(localization_launch, ground_segmentation_launch): rename lidar topic #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
github-actions
bot
added
the
component:launch
YamatoAndo
requested review from
miursh,
YoshiRi,
yukkysaito,
KYabuuchi,
kminoda and
RyuYamamoto
as code owners
This was referenced Dec 5, 2023
Merged
KYabuuchi
approved these changes
Dec 6, 2023
YamatoAndo
added
the
tag:run-build-and-test-differential
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ar topic (autowarefoundation#5781) rename lidar topic Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rename lidar topic of localization_launch and ground_segmentation_launch.
/sensing/lidar/<lidar name>/outlier_filtered/pointcloud-->/sensing/lidar/<lidar name>/pointcloudRelated PRs
Merge all Related PRs at the same time.
autowarefoundation/autoware-documentation#491
#5781
autowarefoundation/sample_sensor_kit_launch#82
autowarefoundation/autoware_launch#722
tier4/awsim_sensor_kit_launch#12
autowarefoundation/awf_reference_sensor_kit_launch#7
Tests performed
LSim works.
Effects on system behavior
rename lidar topic of localization_launch and ground_segmentation_launch.
/sensing/lidar/<lidar name>/outlier_filtered/pointcloud-->/sensing/lidar/<lidar name>/pointcloudPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.