-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ground_segmentation): rename topic and node #6536
chore(ground_segmentation): rename topic and node #6536
Conversation
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miursh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6536 +/- ##
=======================================
Coverage 15.19% 15.19%
=======================================
Files 1851 1851
Lines 128449 128449
Branches 39228 39228
=======================================
Hits 19519 19519
Misses 87138 87138
Partials 21792 21792
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@YoshiRi @yukkysaito Could you approve this PR as code owner of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore(ground_segmentation): rename topic and node Signed-off-by: badai-nguyen <[email protected]> * docs: update synchronized_grid_map_fusion Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…#6536) * chore(ground_segmentation): rename topic and node Signed-off-by: badai-nguyen <[email protected]> * docs: update synchronized_grid_map_fusion Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…#6536) * chore(ground_segmentation): rename topic and node Signed-off-by: badai-nguyen <[email protected]> * docs: update synchronized_grid_map_fusion Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
…#6536) * chore(ground_segmentation): rename topic and node Signed-off-by: badai-nguyen <[email protected]> * docs: update synchronized_grid_map_fusion Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
…#6536) * chore(ground_segmentation): rename topic and node Signed-off-by: badai-nguyen <[email protected]> * docs: update synchronized_grid_map_fusion Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
Description
Related Link
TIER IV INTERNAL LINK
Tests performed
I confirmed by
loggging-simulator
:The node and topic name have been updated:
Ground_segmentation worked and output result as before.
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.