Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): rename topic and node #6536

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 4, 2024

Description

  • Rename to more reasonable topic name of ground_segmentation pipeline.

Related Link

TIER IV INTERNAL LINK

Tests performed

  • I confirmed by loggging-simulator:

  • The node and topic name have been updated:
    image

  • Ground_segmentation worked and output result as before.
    image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen requested a review from kminoda March 4, 2024 04:29
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Mar 4, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review March 4, 2024 04:58
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Could you also fix synchronized_grid_map_fusion.md as well?

image

@badai-nguyen badai-nguyen requested a review from soblin as a code owner March 4, 2024 06:03
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 4, 2024
@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Mar 4, 2024

@kminoda I fixed at 3a0848f

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.19%. Comparing base (833722b) to head (3a0848f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6536   +/-   ##
=======================================
  Coverage   15.19%   15.19%           
=======================================
  Files        1851     1851           
  Lines      128449   128449           
  Branches    39228    39228           
=======================================
  Hits        19519    19519           
  Misses      87138    87138           
  Partials    21792    21792           
Flag Coverage Δ *Carryforward flag
differential 27.17% <ø> (?)
total 15.19% <ø> (ø) Carriedforward from 833722b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen
Copy link
Contributor Author

@YoshiRi @yukkysaito Could you approve this PR as code owner of probabilistic_occupancy_grid_map package 🙇

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 59f7031 into autowarefoundation:main Mar 5, 2024
31 of 32 checks passed
@badai-nguyen badai-nguyen deleted the chore/rename_ground_segment_topic branch March 5, 2024 00:58
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* chore(ground_segmentation): rename topic and node

Signed-off-by: badai-nguyen <[email protected]>

* docs: update synchronized_grid_map_fusion

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…#6536)

* chore(ground_segmentation): rename topic and node

Signed-off-by: badai-nguyen <[email protected]>

* docs: update synchronized_grid_map_fusion

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Apr 22, 2024
…#6536)

* chore(ground_segmentation): rename topic and node

Signed-off-by: badai-nguyen <[email protected]>

* docs: update synchronized_grid_map_fusion

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
…#6536)

* chore(ground_segmentation): rename topic and node

Signed-off-by: badai-nguyen <[email protected]>

* docs: update synchronized_grid_map_fusion

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…#6536)

* chore(ground_segmentation): rename topic and node

Signed-off-by: badai-nguyen <[email protected]>

* docs: update synchronized_grid_map_fusion

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants