Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_stop_planner): rework parameters #7373

Closed

Conversation

Ariiees
Copy link
Contributor

@Ariiees Ariiees commented Jun 7, 2024

Description

Implement the ROS Node configuration layout for the obstacle_stop_planner package.

Test performed

  1. Build colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to obstacle_cruise_planner
  2. Launch ros2 launch obstacle_stop_planner obstacle_stop_planner.launch.xml

Notes for reviewers

None

Interface Changes

  1. Create 3 schema.json files
  2. Update README.md

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.
    After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 7, 2024
@mitsudome-r
Copy link
Member

@Ariiees Thanks for the PR.

However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits?

For example by running the following command:
git rebase -i --signoff origin/main

@Ariiees
Copy link
Contributor Author

Ariiees commented Jun 20, 2024

@Ariiees Thanks for the PR.

However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits?

For example by running the following command: git rebase -i --signoff origin/main

Sure! Thank you for your suggestion. I've already rebase and sign it on the latest branch

@Ariiees Ariiees closed this Jul 2, 2024
@Ariiees Ariiees force-pushed the obstacle_stop_planner branch from b2df9a8 to d5882c9 Compare July 2, 2024 14:12
Copy link

github-actions bot commented Jul 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r
Copy link
Member

@Ariiees Could you tell me why you closed this PR?

@mitsudome-r
Copy link
Member

Never mind, I noticed that you recreated the PR: #7795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants