-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix missing namespaces in C++ code #9477
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Esteve Fernandez <[email protected]>
fef5982
to
74370bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9477 +/- ##
==========================================
- Coverage 29.44% 29.44% -0.01%
==========================================
Files 1443 1442 -1
Lines 108560 108565 +5
Branches 41533 41535 +2
==========================================
- Hits 31970 31967 -3
- Misses 73476 73486 +10
+ Partials 3114 3112 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have confirmed that service_log_checker_node
and autoware_traffic_light_recognition_marker_publisher_node
are running..
@isamu-takagi thanks for the review |
Description
I noticed that the plugins were missing namespaces, this PR adds namespaces in the code and in the plugin definitions in CMake.
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.