Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing namespaces in C++ code #9477

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 26, 2024

Description

I noticed that the plugins were missing namespaces, this PR adds namespaces in the code and in the plugin definitions in CMake.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve requested a review from isamu-takagi as a code owner November 26, 2024 13:45
@esteve esteve self-assigned this Nov 26, 2024
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 26, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the fix-namespace-plugins branch from fef5982 to 74370bb Compare November 26, 2024 13:50
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.44%. Comparing base (f9159c1) to head (74370bb).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ponent_interface_tools/src/service_log_checker.cpp 0.00% 1 Missing ⚠️
...src/traffic_light_recognition_marker_publisher.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9477      +/-   ##
==========================================
- Coverage   29.44%   29.44%   -0.01%     
==========================================
  Files        1443     1442       -1     
  Lines      108560   108565       +5     
  Branches    41533    41535       +2     
==========================================
- Hits        31970    31967       -3     
- Misses      73476    73486      +10     
+ Partials     3114     3112       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.44% <ø> (-0.01%) ⬇️ Carriedforward from f9159c1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have confirmed that service_log_checker_node and autoware_traffic_light_recognition_marker_publisher_node are running..

@esteve esteve merged commit bf9b1c2 into autowarefoundation:main Nov 27, 2024
32 checks passed
@esteve esteve deleted the fix-namespace-plugins branch November 27, 2024 09:20
@esteve
Copy link
Contributor Author

esteve commented Nov 27, 2024

@isamu-takagi thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants