Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception_reproducer): fix a small bug #155

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix(perception_reproducer): fix a small bug #155

merged 2 commits into from
Nov 22, 2024

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Nov 20, 2024

Description

fix the bug that perception_reproducer doesn't work when without '-p'.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! and sorry for my mistake 🙇

xtk8532704 and others added 2 commits November 20, 2024 14:04
Signed-off-by: temkei.kem <[email protected]>
@xtk8532704 xtk8532704 merged commit 2e13bf2 into main Nov 22, 2024
25 checks passed
@xtk8532704 xtk8532704 deleted the fix-bug branch November 22, 2024 02:15
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ad0b811) to head (4a839e6).
Report is 75 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #155      +/-   ##
========================================
- Coverage   2.12%   0.00%   -2.13%     
========================================
  Files        163       4     -159     
  Lines       9402     144    -9258     
  Branches     383       0     -383     
========================================
- Hits         200       0     -200     
+ Misses      9045     144    -8901     
+ Partials     157       0     -157     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants