Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common_awsim_labs_sensor_launch): filter load from parameter file #8

Closed

Conversation

vividf
Copy link

@vividf vividf commented Oct 22, 2024

Description

Related:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf
Copy link
Author

vividf commented Oct 22, 2024

@xmfcx could you reveiw this, thanks!

@vividf vividf changed the title feature: filter load from parameter file feat(common_awsim_labs_sensor_launch): filter load from parameter file Oct 22, 2024
Signed-off-by: vividf <[email protected]>
@xmfcx
Copy link

xmfcx commented Oct 22, 2024

I will look into the precommit problem later on.

Is this ready to be merged now?

Which PR from the universe is this connected to?

@xmfcx
Copy link

xmfcx commented Oct 22, 2024

Sorry it's this one:

I've approved this.

First universe PR should be merged.
Then we can merge these.

@vividf
Copy link
Author

vividf commented Nov 7, 2024

I'll close this one for now since it makes the nodes harder to maintain.

@vividf vividf closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants