Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set tmpnet exports for CLI interface #3727

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

set tmpnet exports for CLI interface #3727

wants to merge 5 commits into from

Conversation

felipemadero
Copy link
Contributor

Why this should be merged

Defines some exports as needed by CLI integration of tmpnet

How this works

How this was tested

Need to be documented in RELEASES.md?

This was referenced Feb 18, 2025
Open
Merged
maru-ava
maru-ava reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@maru-ava maru-ava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment or docstring to each of the exported methods communicating to future maintainers the need to keep them exported despite the lack of consumers within avalanchego.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maru-ava maru-ava maru-ava approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipemadero @maru-ava