Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple accounts #1879

Merged
merged 9 commits into from
Aug 16, 2024
Merged

Use multiple accounts #1879

merged 9 commits into from
Aug 16, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Aug 16, 2024

Problem

E2E test load is running into throttling problems.

Issue number, if available:
#1821

Changes

Add 2 more accounts. In such a way that:

  1. An array with strings containing account numbers is defined as "Action variable" (see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables)
  2. Cleanup job is using that list to add second dimension to and generate cleanup jobs per account and region
  3. Health check workflow is randomly selecting account for each step that requires it

Out of scope

  1. Canaries are not included in this PR.
  2. I tried extracting action, but ended up with similar amount of code per each step. So I backed out from that approach.

Corresponding docs PR, if applicable:

Validation

  1. https://github.com/aws-amplify/amplify-backend/actions/runs/10423731736/job/28871034297
  2. This PR checks.

Seems that accounts are being selected.

image
image
image

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Aug 16, 2024
Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: 4204c50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

scripts/select_e2e_test_account.ts Dismissed Show dismissed Hide dismissed
@sobolk sobolk marked this pull request as ready for review August 16, 2024 18:49
@sobolk sobolk requested review from a team as code owners August 16, 2024 18:49
@sobolk sobolk merged commit d755f74 into main Aug 16, 2024
57 checks passed
@sobolk sobolk deleted the use-multiple-accounts branch August 16, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants