Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple accounts in canary workflow #1902

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Aug 21, 2024

Problem

Canary workflow doesn't use multiple e2e accounts yet.

Previous PR that introduced multiple accounts to health checks #1879 .

Changes

  1. Create action to encapsulate account selection logic.
  2. Use it canaries in addition to health checks.

Validation

  1. This PR checks
  2. Canary run https://github.com/aws-amplify/amplify-backend/actions/runs/10497624775

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Aug 21, 2024
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 9c414ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sobolk sobolk marked this pull request as ready for review August 21, 2024 21:56
@sobolk sobolk requested a review from a team as a code owner August 21, 2024 21:56
@Amplifiyer
Copy link
Contributor

Will this be the place to see which account is being used?

Screenshot 2024-08-22 at 18 17 33

Also are we randomizing the region as well? In case same account is given to multiple test runners?

@sobolk
Copy link
Member Author

sobolk commented Aug 22, 2024

Will this be the place to see which account is being used?

That's one of the places. The other (already existing) is deployment log in the job logs (there's account ID in ARNs that are printed there).

image

Also are we randomizing the region as well? In case same account is given to multiple test runners?

We do not. For canaries it wouldn't make much sense as randomizing [random_account, region] is already achieving uniform distribution across both dimensions.

This is however a good idea to explore for health checks. But I'd rather do that in separate PR.

Also keep in mind that our objective in canary job is to run checks in all regions in the matrix. In health checks spreading load across randomly selected region would help with avoiding throttling with less accounts.

@sobolk sobolk merged commit b7df05a into main Aug 22, 2024
62 checks passed
@sobolk sobolk deleted the use-accounts-in-canaries branch August 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants