Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error names in storage and functions. #1883

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix error names in storage and functions. #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/kind-drinks-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@aws-amplify/backend-function': patch
'@aws-amplify/backend-storage': patch
---

Fix InvalidFunctionConfigurationError and InvalidStorageAccessDefinitionError error names.
2 changes: 1 addition & 1 deletion packages/backend-function/src/function_env_translator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ void describe('FunctionEnvironmentTranslator', () => {
);
},
{
name: 'InvalidFunctionConfiguration',
name: 'InvalidFunctionConfigurationError',
}
);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-function/src/function_env_translator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class FunctionEnvironmentTranslator {
);
}
if (typeof value === 'undefined') {
throw new AmplifyUserError('InvalidFunctionConfiguration', {
throw new AmplifyUserError('InvalidFunctionConfigurationError', {
message: `The value of environment variable ${key} is undefined.`,
resolution: `Ensure that all defineFunction environment variables are defined.`,
});
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-storage/src/private_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { StorageAction } from './types.js';
* Storage user error types
*/
export type StorageError =
| 'InvalidStorageAccessDefinition'
| 'InvalidStorageAccessDefinitionError'
| 'InvalidStorageAccessPathError';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-storage/src/storage_access_orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class StorageAccessOrchestrator {
({ uniqueDefinitionId, validationErrorOptions }) => {
if (uniqueDefinitionIdSet.has(uniqueDefinitionId)) {
throw new AmplifyUserError<StorageError>(
'InvalidStorageAccessDefinition',
'InvalidStorageAccessDefinitionError',
validationErrorOptions
);
} else {
Expand Down