-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StructuredEncryption smithy model and stubbed APIs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
reviewed
Aug 18, 2022
texastony
reviewed
Aug 20, 2022
src/StructuredEncryption/model/AwsCryptographyStructuredEncryptionTypes.dfy
Outdated
Show resolved
Hide resolved
…tionTypes.dfy Co-authored-by: Tony Knapp <[email protected]>
texastony
reviewed
Aug 23, 2022
texastony
reviewed
Aug 23, 2022
texastony
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks groovy.
I do not know what is going on with History
or the Modifies stuff.
I have a few nitpicks and questions.
src/StructuredEncryption/model/AwsCryptographyStructuredEncryptionTypes.dfy
Outdated
Show resolved
Hide resolved
src/StructuredEncryption/src/Operations/EncryptStructureOperation.dfy
Outdated
Show resolved
Hide resolved
texastony
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Define the Smithy model and creates stubs for the new StructuredEncryption APIs. Added minimal input validation; when we come in with the spec/duvet next we can ensure that this input validation is complete. Code is verified and the HappyTestCase can successfully run via .NET.
I removed the generated C# files, as Polymorph doesn't handle unions in C# correctly. Thus there is no E2E C# examples.
The build structure and tooling is still WIP, and likely to change as we make progress on the MPL. For now, it is adequate for verifying/building/running this code in Dafny.
Testing done via:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.