-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Upcoming v1 #35
Conversation
BREAKING CHANGE: lib return values are now camelCased
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage ? 94.59%
=========================================
Files ? 6
Lines ? 111
Branches ? 13
=========================================
Hits ? 105
Misses ? 5
Partials ? 1
Continue to review full report at Codecov.
|
.travis.yml
Outdated
directories: | ||
- /home/travis/build/technopagan/sqip/vendor | ||
before_install: | ||
- npm install -g npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed as npm is provided with nvm ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely true. Thats a case of copy pasta 🙈
.travis.yml
Outdated
- "8" | ||
cache: | ||
directories: | ||
- /home/travis/build/technopagan/sqip/vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"vendor"? Just know this from PHP. Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U are probably correct here, too. I will remove it and we will see :)
additionally replaces travis with circle ci
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
======================================
Coverage ? 0%
======================================
Files ? 5
Lines ? 100
Branches ? 11
======================================
Hits ? 0
Misses ? 89
Partials ? 11
Continue to review full report at Codecov.
|
Since we now have a |
See #30
This is not ready yet, there is still some stuff to do!
Currently includes:
More to come...
Introduced breaking changes:
-i
argument.sqip foo.jpg
will becomesqip -i foo.jpg