Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Upcoming v1 #35

Merged
merged 25 commits into from
Mar 2, 2019
Merged

[WIP] - Upcoming v1 #35

merged 25 commits into from
Mar 2, 2019

Conversation

axe312ger
Copy link
Owner

@axe312ger axe312ger commented Apr 14, 2018

See #30

This is not ready yet, there is still some stuff to do!

Currently includes:

  • Updated dependencies (except svgo, needs async logic first)
  • Integrate eslint && prettier
  • Add unit and e2e tests via jest and nixt
  • Replace unmaintained argv with yargs. Allows more complex cli argument parsing. Especially helpful for later on.
  • Refactors SVG optimization

More to come...

Introduced breaking changes:

  • The input file for the CLI now has to be passed via the -i argument. sqip foo.jpg will become sqip -i foo.jpg

@axe312ger axe312ger mentioned this pull request Apr 17, 2018
7 tasks
@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d8d44e9). Click here to learn what that means.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   94.59%           
=========================================
  Files             ?        6           
  Lines             ?      111           
  Branches          ?       13           
=========================================
  Hits              ?      105           
  Misses            ?        5           
  Partials          ?        1
Impacted Files Coverage Δ
src/cli.js 0% <0%> (ø)
src/node.js 0% <0%> (ø)
src/utils/helpers.js 100% <100%> (ø)
src/utils/primitive.js 100% <100%> (ø)
src/utils/svg.js 100% <100%> (ø)
src/index.js 92.85% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d44e9...00c550c. Read the comment docs.

This was referenced Jun 11, 2018
.travis.yml Outdated
directories:
- /home/travis/build/technopagan/sqip/vendor
before_install:
- npm install -g npm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as npm is provided with nvm ;-)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely true. Thats a case of copy pasta 🙈

.travis.yml Outdated
- "8"
cache:
directories:
- /home/travis/build/technopagan/sqip/vendor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"vendor"? Just know this from PHP. Is this really needed?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U are probably correct here, too. I will remove it and we will see :)

@axe312ger axe312ger mentioned this pull request Jul 13, 2018
@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d8d44e9). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #35   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     5           
  Lines             ?   100           
  Branches          ?    11           
======================================
  Hits              ?     0           
  Misses            ?    89           
  Partials          ?    11
Impacted Files Coverage Δ
src/cli.js 0% <0%> (ø)
src/utils/svg.js 0% <0%> (ø)
src/index.js 0% <0%> (ø)
src/utils/helpers.js 0% <0%> (ø)
src/utils/primitive.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d44e9...eb50f5d. Read the comment docs.

@axe312ger
Copy link
Owner Author

Since we now have a legacy branch, I gonna merge this to master to reflect the current progress :)

@axe312ger axe312ger merged commit bf4908e into master Mar 2, 2019
@axe312ger axe312ger deleted the next branch March 2, 2019 08:33
@axe312ger axe312ger mentioned this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants