Closes #37 Add Twitter X icon #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
All the other logos we have in this repo are a "reversed" style where the logo is transparent within a solid background -- see https://github.com/az-digital/az-icons/blob/main/dist/png/twitter.png for example. I think this PR should proceed in the same fashion. |
trackleft
reviewed
Oct 6, 2023
trackleft
reviewed
Oct 6, 2023
Co-authored-by: Chris Green <[email protected]>
Co-authored-by: Chris Green <[email protected]>
|
Nitpick suggestion: Maybe we should use |
joeparsons
reviewed
Oct 13, 2023
Co-authored-by: Joe Parsons <[email protected]>
danahertzberg
previously approved these changes
Oct 13, 2023
Co-authored-by: Chris Green <[email protected]>
joeparsons
approved these changes
Oct 13, 2023
danahertzberg
approved these changes
Oct 13, 2023
camikazegreen
approved these changes
Oct 13, 2023
This was referenced Feb 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't feel comfortable overwriting az-icon-twitter, instead I added az-icon-x. This will allow those who may have some reason to keep the az-icon-twitter icon active the option while also allowing those needing to use the rebranded twitter (now X) the option to do so.