Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename app field #506

Merged
merged 29 commits into from
Jul 18, 2024
Merged

Rename app field #506

merged 29 commits into from
Jul 18, 2024

Conversation

disrupted
Copy link
Member

@disrupted disrupted commented Jul 8, 2024 •
edited
Loading

Closes #502

connector: config
kubernetes-app (and children): values

global KpopsConfig and ComponentHandlers (naive singleton implementation), no longer needs to be passed during component initialization

examples test depends on bakdata/kpops-examples#24

@disrupted disrupted added type/refactor Refactoring of existing functionality component/generator Related to the generation of pipeline.yaml component/pipeline-components Related to pipeline components breaking-change Indicates that this PR introduces a breaking change labels Jul 8, 2024
@disrupted disrupted self-assigned this Jul 8, 2024
@disrupted disrupted changed the base branch from main to v7 July 8, 2024 17:40
disrupted added 20 commits July 8, 2024 20:00
@disrupted disrupted marked this pull request as ready for review July 10, 2024 08:42
@disrupted disrupted requested a review from raminqaf as a code owner July 10, 2024 08:42
disrupted added 2 commits July 10, 2024 10:59
@disrupted
Resolve circular import
3d5af48 
Fix missing file
@disrupted
Remove usage of Self
1cf258f 
breaks Python 3.10 support
raminqaf
raminqaf reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@raminqaf raminqaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort! I left some comments! I prefer to have the singleton and the config/value renaming in two different PRs to see the diff a bit easier.

docs/docs/user/migration-guide/v6-v7.md Show resolved Hide resolved
kpops/component_handlers/__init__.py Show resolved Hide resolved
kpops/component_handlers/__init__.py Show resolved Hide resolved
kpops/config/__init__.py Show resolved Hide resolved
kpops/config/__init__.py Show resolved Hide resolved
tests/components/test_base_defaults_component.py Show resolved Hide resolved
@raminqaf raminqaf self-requested a review July 15, 2024 09:53
raminqaf
raminqaf reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@raminqaf raminqaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts needs to be resolved 😃

@raminqaf
Copy link
Contributor

Let's go v7! 🚀 7️⃣

@disrupted disrupted merged commit 5e1e2d2 into v7 Jul 18, 2024
9 checks passed
@disrupted disrupted deleted the refactor/app branch July 18, 2024 14:51
@raminqaf raminqaf mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raminqaf raminqaf raminqaf approved these changes

Assignees

@disrupted disrupted

Labels
breaking-change Indicates that this PR introduces a breaking change component/generator Related to the generation of pipeline.yaml component/pipeline-components Related to pipeline components type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename generic app config to something more specific
2 participants
@disrupted @raminqaf