Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename app field #506

Merged
merged 29 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0983a48
Rename app field
disrupted Jul 8, 2024
9317961
Merge remote-tracking branch 'origin/v7' into refactor/app
disrupted Jul 8, 2024
cbff01c
Update test
disrupted Jul 8, 2024
20368ae
Try solve circular import
disrupted Jul 8, 2024
4286880
Update test resources
disrupted Jul 8, 2024
b2c657c
Update test
disrupted Jul 8, 2024
6dfae50
Update test resources
disrupted Jul 8, 2024
885fdb4
Update snapshots
disrupted Jul 8, 2024
ed8b71d
Update test resources
disrupted Jul 8, 2024
b8f3649
Update examples
disrupted Jul 8, 2024
8988667
Update snapshots of example pipelines
disrupted Jul 8, 2024
174775d
Revert PrivateAttr
disrupted Jul 8, 2024
d7263b8
Update docstring
disrupted Jul 8, 2024
ed96277
Update test
disrupted Jul 8, 2024
0c26629
Add migration guide
disrupted Jul 9, 2024
c8471e4
Explore naive approach for global KpopsConfig
disrupted Jul 9, 2024
0094054
Try singleton decorator
disrupted Jul 9, 2024
0a5ce92
Revert "Try singleton decorator"
disrupted Jul 9, 2024
4ee539f
Fix optional type
disrupted Jul 9, 2024
68704c5
Refactor global component handlers as singleton
disrupted Jul 9, 2024
776bbad
Merge remote-tracking branch 'origin/main' into refactor/app
disrupted Jul 9, 2024
a4f6b22
Drop values when instantiating connector resetter
disrupted Jul 9, 2024
208fc2f
Refactor
disrupted Jul 10, 2024
ad4e6f3
Refactor
disrupted Jul 10, 2024
3d5af48
Resolve circular import
disrupted Jul 10, 2024
1cf258f
Remove usage of `Self`
disrupted Jul 10, 2024
ba13795
Merge branch 'v7' into refactor/app
disrupted Jul 10, 2024
8d9c9b9
Merge remote-tracking branch 'origin/v7' into refactor/app
disrupted Jul 17, 2024
3f70c7a
Remove unnecessary fixture
disrupted Jul 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
helm-app.yaml:
- app-helm-app.yaml
- values-helm-app.yaml
- repo_config-helm-app.yaml
kafka-app.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- app-kafka-app.yaml
- values-kafka-app.yaml
kafka-connector.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- app-kafka-connector.yaml
- config-kafka-connector.yaml
- resetter_values.yaml
kafka-sink-connector.yaml: []
kafka-source-connector.yaml:
Expand All @@ -21,9 +21,9 @@ kubernetes-app.yaml:
- from_.yaml
- to.yaml
- namespace.yaml
- app-kubernetes-app.yaml
- values-kubernetes-app.yaml
producer-app.yaml:
- from_-producer-app.yaml
- app-producer-app.yaml
- values-producer-app.yaml
streams-app.yaml:
- app-streams-app.yaml
- values-streams-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,37 +5,37 @@ kpops_components_fields:
- from_
- to
- namespace
- app
- values
- repo_config
- version
kafka-app:
- name
- prefix
- from_
- to
- app
- values
kafka-connector:
- name
- prefix
- from_
- to
- app
- config
- resetter_namespace
- resetter_values
kafka-sink-connector:
- name
- prefix
- from_
- to
- app
- config
- resetter_namespace
- resetter_values
kafka-source-connector:
- name
- prefix
- from_
- to
- app
- config
- resetter_namespace
- resetter_values
- offset_topic
Expand All @@ -45,7 +45,7 @@ kpops_components_fields:
- from_
- to
- namespace
- app
- values
pipeline-component:
- name
- prefix
Expand All @@ -57,7 +57,7 @@ kpops_components_fields:
- from_
- to
- namespace
- app
- values
- repo_config
- version
streams-app:
Expand All @@ -66,7 +66,7 @@ kpops_components_fields:
- from_
- to
- namespace
- app
- values
- repo_config
- version
streams-bootstrap:
Expand All @@ -75,7 +75,7 @@ kpops_components_fields:
- from_
- to
- namespace
- app
- values
- repo_config
- version
kpops_components_inheritance_ref:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,52 +3,52 @@ helm-app.yaml:
- from_.yaml
- to.yaml
- namespace.yaml
- app-helm-app.yaml
- values-helm-app.yaml
- repo_config-helm-app.yaml
- version.yaml
kafka-app.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- app-kafka-app.yaml
- values-kafka-app.yaml
kafka-connector.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- app-kafka-connector.yaml
- config-kafka-connector.yaml
- resetter_values.yaml
kafka-sink-connector.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- app-kafka-connector.yaml
- config-kafka-connector.yaml
- resetter_values.yaml
kafka-source-connector.yaml:
- prefix.yaml
- from_-kafka-source-connector.yaml
- to.yaml
- app-kafka-connector.yaml
- config-kafka-connector.yaml
- resetter_values.yaml
- offset_topic-kafka-source-connector.yaml
kubernetes-app.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- namespace.yaml
- app-kubernetes-app.yaml
- values-kubernetes-app.yaml
producer-app.yaml:
- prefix.yaml
- from_-producer-app.yaml
- to.yaml
- namespace.yaml
- app-producer-app.yaml
- values-producer-app.yaml
- repo_config-helm-app.yaml
- version-kafka-app.yaml
streams-app.yaml:
- prefix.yaml
- from_.yaml
- to.yaml
- namespace.yaml
- app-streams-app.yaml
- values-streams-app.yaml
- repo_config-helm-app.yaml
- version-kafka-app.yaml
4 changes: 1 addition & 3 deletions docs/docs/resources/pipeline-components/helm-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
models: # SchemaProvider is initiated with the values given here
model: model
namespace: namespace # required
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example.
app: # required
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
Expand Down
4 changes: 1 addition & 3 deletions docs/docs/resources/pipeline-components/kafka-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` can contain application-specific settings, hence the user is free to
# add the key-value pairs they need.
app: # required
values: # required
streams: # required
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down
6 changes: 2 additions & 4 deletions docs/docs/resources/pipeline-components/kafka-connector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,8 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example. Extensive documentation on
# connectors: https://kafka.apache.org/documentation/#connectconfigs
app: # required
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
# Overriding Kafka Connect Resetter Helm values. E.g. to override the
# Image Tag etc.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example. Extensive documentation on
# connectors: https://kafka.apache.org/documentation/#connectconfigs
app: # required
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
# Overriding Kafka Connect Resetter Helm values. E.g. to override the
# Image Tag etc.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example. Extensive documentation on
# connectors: https://kafka.apache.org/documentation/#connectconfigs
app: # required
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
# Overriding Kafka Connect Resetter Helm values. E.g. to override the
# Image Tag etc.
Expand Down
4 changes: 1 addition & 3 deletions docs/docs/resources/pipeline-components/kubernetes-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
models: # SchemaProvider is initiated with the values given here
model: model
namespace: namespace # required
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example.
app: # required
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
28 changes: 9 additions & 19 deletions docs/docs/resources/pipeline-components/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@
models: # SchemaProvider is initiated with the values given here
model: model
namespace: namespace # required
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example.
app: # required
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
Expand Down Expand Up @@ -107,9 +105,7 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` can contain application-specific settings, hence the user is free to
# add the key-value pairs they need.
app: # required
values: # required
streams: # required
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down Expand Up @@ -160,10 +156,8 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example. Extensive documentation on
# connectors: https://kafka.apache.org/documentation/#connectconfigs
app: # required
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
# Overriding Kafka Connect Resetter Helm values. E.g. to override the
# Image Tag etc.
Expand Down Expand Up @@ -195,10 +189,8 @@
cleanup.policy: compact
models: # SchemaProvider is initiated with the values given here
model: model
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example. Extensive documentation on
# connectors: https://kafka.apache.org/documentation/#connectconfigs
app: # required
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
# Overriding Kafka Connect Resetter Helm values. E.g. to override the
# Image Tag etc.
Expand Down Expand Up @@ -253,9 +245,7 @@
models: # SchemaProvider is initiated with the values given here
model: model
namespace: namespace # required
# `app` contains application-specific settings, hence it does not have a rigid
# structure. The fields below are just an example.
app: # required
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
Expand Down Expand Up @@ -291,7 +281,7 @@
namespace: namespace # required
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/producer-app
app: # required
values: # required
streams: # required, producer-app-specific
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down Expand Up @@ -361,7 +351,7 @@
# No arbitrary keys are allowed under `app`here
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/streams-app
app: # required
values: # required
# Streams Bootstrap streams section
streams: # required, streams-app-specific
brokers: ${config.kafka_brokers} # required
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/resources/pipeline-components/producer-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
namespace: namespace # required
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/producer-app
app: # required
values: # required
streams: # required, producer-app-specific
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Full documentation on connectors: https://kafka.apache.org/documentation/#connectconfigs
config: # required
tasks.max: 1
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# `app` can contain application-specific settings, hence the user is free to
# add the key-value pairs they need.
app: # required
values: # required
streams: # required
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
values: # required
image: exampleImage # Example
debug: false # Example
commandLine: {} # Example
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/producer-app
app: # required
values: # required
streams: # required, producer-app-specific
brokers: ${config.kafka_brokers} # required
schemaRegistryUrl: ${config.schema_registry.url}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# No arbitrary keys are allowed under `app`here
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/streams-app
app: # required
values: # required
# Streams Bootstrap streams section
streams: # required, streams-app-specific
brokers: ${config.kafka_brokers} # required
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/resources/pipeline-components/streams-app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
# No arbitrary keys are allowed under `app`here
# Allowed configs:
# https://github.com/bakdata/streams-bootstrap/tree/master/charts/streams-app
app: # required
values: # required
# Streams Bootstrap streams section
streams: # required, streams-app-specific
brokers: ${config.kafka_brokers} # required
Expand Down
Loading
Loading