Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INSPECT-301] FEATURE** Add buttons for Bilge Plugs #312

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Jun 4, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

Note, this PR is currently pointing at the .dev API and is not intended for use in production. we use Dev when letting users test the application in Testflight so not to cloud production with false data. a future PR will be made to change the target back to .prod once testing is approved.

This PR includes the following proposed change(s):

  • Addition of two new buttons in Watercraft Inspections [Figure 1.]
    • Does the watercraft have a drain plug located on the lower transom? added to main form
    • Was the drain plug removed at the time of inspection -- Conditional question if previous button checked yes
  • Buttons implemented into forms existing logic
  • Simplification of existing [Figure 2.] Other Waterbody form field [Figure 3.]
    • Users were adding extra details here, then had to add a Nearest Major City from a set table causing confusion and data mismatch (We don't let them create their own Major Cities)

image

[Figure 1. New buttons]

image

[Figure 2. Old Waterbody form field]

image

[Figure 3. New Other Waterbody form field]

@LocalNewsTV LocalNewsTV marked this pull request as ready for review June 4, 2024 20:17
@LocalNewsTV LocalNewsTV requested a review from a team June 4, 2024 20:18
@LocalNewsTV LocalNewsTV linked an issue Jun 4, 2024 that may be closed by this pull request
5 tasks
@LocalNewsTV LocalNewsTV merged commit 1e7349c into master Jun 6, 2024
1 check passed
@LocalNewsTV LocalNewsTV deleted the 301-bilge-plug-buttons branch June 6, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bilge plug fields to inspection form
3 participants