Merge branch 'support/client2' into fix/FSADT1-1511

bcgov · Sep 24, 2024 · 4bb6ff5 · 4bb6ff5
2 parents 246e8cb + d4dd307
commit 4bb6ff5
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/frontend/cypress/e2e/pages/staffform/BcRegisteredClientInformationWizardStep.cy.ts b/frontend/cypress/e2e/pages/staffform/BcRegisteredClientInformationWizardStep.cy.ts
@@ -445,21 +445,21 @@ describe("BC Registered Staff Wizard Step", () => {
         }
 
         if (scenario.showData) {
-          const success = Object.entries(scenario)
-            .filter(
-              ([key, value]) =>
-                key.startsWith("show") && key.endsWith("Notification")
-            )
-            .map(([key, value]) => value)
-            .every((value) => value === false);
+          /*
+          This variable might be useful in the future to test the button Next gets enabled on
+          success. But we'll probably need to fix FSADT1-1496 first.
+          */
+          // const success = Object.entries(scenario)
+          //   .filter(
+          //     ([key, value]) =>
+          //       key.startsWith("show") && key.endsWith("Notification")
+          //   )
+          //   .map(([key, value]) => value)
+          //   .every((value) => value === false);
 
           cy.get(
             ".read-only-box > cds-inline-notification#readOnlyNotification"
-          ).should(
-            success || scenario.showDuplicatedNotification
-              ? "exist"
-              : "not.exist"
-          );
+          ).should("exist");
 
           cy.get(`.read-only-box > #legalType > .title-group-01 > .label-01`)
             .should("exist")

diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -56,7 +56,7 @@
     "@vueuse/core": "^11.1.0",
     "aws-amplify": "^6.3.5",
     "axios": "^1.7.2",
-    "date-fns": "^3.0.0",
+    "date-fns": "^4.0.0",
     "dotenv": "^16.0.0",
     "vue": "^3.5.6",
     "vue-dompurify-html": "^5.0.1",

diff --git a/frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue b/frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue
@@ -397,7 +397,6 @@ onMounted(() => {
       <cds-inline-notification
       id="readOnlyNotification"
       v-shadow="2"
-      v-if="formData.businessInformation.goodStandingInd === 'Y' || showOnError"
       low-contrast="true"
       open="true"
       kind="info"