Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe: FSADT1-1495): Add notification to all BC Registries cards in step 1 #1171

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix(fe: FSADT1-1495): Add notification to all BC Registries cards in step 1 #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0175151
fix: show the Read-only notification always
fterra-encora Sep 20, 2024
ad9ec2e
Merge branch 'support/client2' into fix/FSADT1-1495
fterra-encora Sep 23, 2024
905606c
Merge branch 'support/client2' into fix/FSADT1-1495
fterra-encora Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions frontend/cypress/e2e/pages/staffform/BcRegisteredClientInformationWizardStep.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,21 +445,21 @@ describe("BC Registered Staff Wizard Step", () => {
}

if (scenario.showData) {
const success = Object.entries(scenario)
.filter(
([key, value]) =>
key.startsWith("show") && key.endsWith("Notification")
)
.map(([key, value]) => value)
.every((value) => value === false);
/*
This variable might be useful in the future to test the button Next gets enabled on
success. But we'll probably need to fix FSADT1-1496 first.
*/
// const success = Object.entries(scenario)
// .filter(
// ([key, value]) =>
// key.startsWith("show") && key.endsWith("Notification")
// )
// .map(([key, value]) => value)
// .every((value) => value === false);

cy.get(
".read-only-box > cds-inline-notification#readOnlyNotification"
).should(
success || scenario.showDuplicatedNotification
? "exist"
: "not.exist"
);
).should("exist");

cy.get(`.read-only-box > #legalType > .title-group-01 > .label-01`)
.should("exist")
Expand Down
1 change: 0 additions & 1 deletion frontend/src/pages/staffform/BcRegisteredClientInformationWizardStep.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ onMounted(() => {
<cds-inline-notification
id="readOnlyNotification"
v-shadow="2"
v-if="formData.businessInformation.goodStandingInd === 'Y' || showOnError"
low-contrast="true"
open="true"
kind="info"
Expand Down
Loading