fix(fe: FSADT1-1495): Add notification to all BC Registries cards in step 1 #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current changelogBug Fixes
Features
|
|
|
|
mamartinezmejia
requested changes
Sep 23, 2024
The commented code has a comment above it to explain why it was kept there and a reference to a Jira ticket to deal with that in the future (FSADT1-1496). |
MAMM: Yes, it is ok |
mamartinezmejia
approved these changes
Sep 24, 2024
|
mamartinezmejia
temporarily deployed
to
tools
GitHub Actions
Inactive
This was referenced Sep 24, 2024
Merged
This was referenced Oct 1, 2024
Merged
paulushcgcj
added a commit
that referenced
this pull request
Oct 1, 2024
* fix(deps): update maven all non-major dependencies * feat(fe:FSADT1-1503): Adjust button and message for the "Need help?" side menu item (#1164) * feat(fe:FSADT1-1445): Change "Logout" icon in "My profile" panel (#1165) * feat(fe:FSADT1-1445): Change "Logout" icon in "My profile" panel * Removed unused import * feat(fe:FSADT1-1502): Adjust logout behavior (#1167) * fix(fe: FSADT1-1427): Autocomplete emitting value twice (#1170) * fix: prevent from re-emitting with value undefined * test: update tests * feat(fe:FSADT1-1510): Load Legal Types description from data convertor (#1169) * fix(deps): update dependency date-fns to v4 * fix(fe: FSADT1-1495): Add notification to all BC Registries cards in step 1 (#1171) fix: show the Read-only notification always * chore: update support/client2 with main (#1175) * fix(deps): update maven all non-major dependencies * fix(deps): update dependency date-fns to v4 (#1173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(fe: FSADT1-1511): Clear business information when a new Client name gets selected (#1176) fix: clear business information when a new client name gets selected * feat(FSADT1-779): adding cypress scenarios (#1139) * feat: adding some cypress code * feat: adding gherking issue template * feat: updated commands and feature files * feat: adding core cypress instructions for user flow * chore: testing env var * chore: testing artifact grab * chore: ci update * chore: debugging * chore: reducing verbosity * chore: removing test data * feat: adding initial sample for creation * docs: updated documentation * feat: clean before run This will make the database remove the test data beforehand. This can affect the manual test too, but is the price for now * fix: fixing clean script * chore: changing strategy for cleanup - Changed strategy for cleanup. First remove everything from the PR database before recreating it. This is required due to tue uncertainty of the data that will be created through cypress and the previous, manual data inserted as well * chore: testing a few new steps * chore: pre-tools cleanup * fix: fixing automation test * fix: fixing staff on automation * chore: changing wait time * chore: adding an address * chore: trying to make a miracle * chore: scale down * chore: changing config * ci: lets do it * chore: some tests * ci: scale down post work and scale up * chore: adding tags to make it easier to find component * chore: updating name part * chore: updating a little bit * chore: adding bceid and bcsc button text * feat: updated login hooks * feat: add tag identifier for internal and external user * feat: added initial bceid * chore: adding contact identification for old screens * chore: changed limits for submission * chore: adding identification to notification * fix: fixing submit instruction * chore: splitting up the instructions * fix: fixed bceid * docs: updated readme for cypress * chore: updating notification identification * fix: fixing automation * feat(FSADT1-779): updating gherkin issue template * feat: added action to generate feature files * docs: updated readme * chore: reverting a change on accordion item title * fix: fixing wrapper * chore: adding decorator config * fix: fixing data-text location * chore: changing data-text location * fix: changing data-text location * fix: fixing contact selector * chore: removing extra data-text * chore: fixing subgroup search * feat(FSADT1-1515): Display informative message when Legal Types are not supported (#1178) * feat(FSADT1-1515): Display informative message when Legal Types are not supported * feat(FSADT1-1515): Display informative message when Legal Types are not supported * Made code reviews --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * feat(FSADT1-779): adding cypress scenarios (#1139) (#1179) * feat(FSADT1-779): adding cypress scenarios (#1139) * feat(FSADT1-779): adding cypress scenarios (#1139) * chore: merge main into client2 to solve conflicts (#1181) * fix(deps): update maven all non-major dependencies * fix(deps): update dependency date-fns to v4 (#1173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(FSADT1-1514): fixed doing business as processing (#1177) - added to external users the DBA field filled - fixed the DBA field on the processor * fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v3.3.4 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * ci(deps): updating deployer and workflows (#1185) * fix(fe: FSADT1-1488): revalidate the date value properly (#1188) fix: validate date of birth on revalidate event * chore: upgrade vue (#1193) chore: upgraded vue * chore: update support/client2 with main (#1192) * fix(deps): update maven all non-major dependencies * fix(deps): update dependency date-fns to v4 (#1173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(FSADT1-1514): fixed doing business as processing (#1177) - added to external users the DBA field filled - fixed the DBA field on the processor * fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v3.3.4 * chore(deps): update maven all non-major dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> Co-authored-by: Maria Martinez <[email protected]> * fix(fe:FSADT1-1508): reset validation when the selected Client name changes (#1191) * fix: reset validation when the selected Client name changes * fix: fix cypress commands declaration --------- Co-authored-by: Maria Martinez <[email protected]> * fix(fe: FSADT1-1421): fix date validation for pasted/autocompleted values (#1187) * fix: fix date validation for pasted/autocompleted values * test: remove .only --------- Co-authored-by: Maria Martinez <[email protected]> * chore: upgrade types node (#1194) chore: upgraded types/node * fix(fe): stop date validation when part of it has an error (#1197) fix: stop validation when any parts have errors * chore: upgraded sass (#1195) * chore: upgrade carbon pictograms (#1196) chore: updgraded carbon pictograms Co-authored-by: Fernando Terra <[email protected]> * chore: upgrade carbon styles (#1198) * chore: upgraded carbon styles * Delete frontend/src/pages/SearchPage.vue * chore: upgrade vue and cypress coverage (#1200) * fix(FSADT1-1514): fixed doing business as processing (#1177) - added to external users the DBA field filled - fixed the DBA field on the processor * chore(deps): update maven all non-major dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Fernando Terra <[email protected]> Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the condition to display the Read-only notification, so it gets always displayed, regardless of the selected Client's "BC Registries standing" value.
Fixes FSADT1-1495
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: