Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing small details on internal page #594

Merged
merged 51 commits into from
Nov 9, 2023
Merged

fix: fixing small details on internal page #594

merged 51 commits into from
Nov 9, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 1, 2023 •
edited
Loading

Description

Fixing small visual and technical issues related to performance and discrepancies.

Related Jiras:

  • FSADT1-829
  • FSADT1-942
  • FSADT1-946
  • FSADT1-949
  • FSADT1-951
  • FSADT1-927
  • FSADT1-933
  • FSADT1-935
  • FSADT1-936
  • FSADT1-937
  • FSADT1-939
  • FSADT1-940

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added java Pull requests that update Java code tests test classes changes source source code changes backend code related to the java backend application fix labels Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

Current changelog

Bug Fixes

  • adjust body-02 text color (d18f681)
  • adjust label-01 text color (bd33c05)
  • adjust Submitter information accordion item (3e84ef7)
  • align modal left margin with the message below (1e3658c)
  • apply style to cds-actionable-notification content (699a2cf)
  • apply the theme color on danger button (e817e68)
  • fixing case for client names (1343587)
  • fixing country code to description (2afdeda)
  • fixing test (ad67844)
  • fixing test (b101013)
  • fixing the matching message (186977f)
  • fixing user id on frontend (71517d2)
  • fixing username on frontend (5043d6e)
  • FSADT1-930: adding close icon on modal (dc1ff6d)
  • FSADT1-930: fixing header style and size (29b596f)
  • FSADT1-930: fixing styles (d121efe)
  • FSADT1-930: fixing submission list icons (c382a48)
  • FSADT1-935: changing hover color (81c4b63)
  • FSADT1-936: fixing mail notification for staff (4f7a56a)
  • FSADT1-939: checking if unregistered has goodstanding (e3d1451)
  • FSADT1-942: fixing timezone issues (4cb43fe)
  • FSADT1-942: fixing timezone issues (68cb08b)
  • FSADT1-946: removing client number and incorporation when empty (fd42857)
  • FSADT1-951: fixing notification after approval (190aab3)
  • remove margin from tags (6d3407d)
  • remove shadow from cds-actionable-notification (6c769e7)
  • remove title shown as tooltip on cds-tag elements (ff0b5f8)
  • scroll to top when changing the route (b4c2ee0)
  • set icon color to the link primary color (5582562)
  • updating submission list query (1b2f8f8)
  • updating submission list query (0674e2c)
  • use rem as unit (fc02225)

Features

  • add custom close button in 'My profile' panel (b76ea4c)
  • show submission approved/rejected toast (38cd619)

@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 16:42 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 16:49 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj marked this pull request as ready for review November 1, 2023 18:14
@paulushcgcj paulushcgcj marked this pull request as draft November 1, 2023 18:16
@github-actions github-actions bot added fix and removed fix labels Nov 1, 2023
@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 19:42 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 19:55 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 23:22 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev November 1, 2023 23:27 — with GitHub Actions Inactive
@github-actions github-actions bot removed the fix label Nov 2, 2023
@github-actions github-actions bot added fix and removed fix labels Nov 9, 2023
@github-actions github-actions bot added fix and removed fix labels Nov 9, 2023
@github-actions github-actions bot added fix and removed fix labels Nov 9, 2023
@github-actions github-actions bot added fix and removed fix labels Nov 9, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

97.6% 97.6% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[forest-client-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@paulushcgcj paulushcgcj merged commit 380e884 into main Nov 9, 2023
19 of 20 checks passed
@paulushcgcj paulushcgcj deleted the fix/fixing-details branch November 9, 2023 20:05
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
10 tasks
@fterra-encora fterra-encora mentioned this pull request Nov 16, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

Assignees

@paulushcgcj paulushcgcj

Labels
backend code related to the java backend application fix frontend java Pull requests that update Java code javascript Pull requests that update Javascript code openshift source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulushcgcj @mamartinezmejia @fterra-encora