[FSADT1-1035] Good standing is not showing as TRUE

[fterra-encora]

Description

The code was refering to a wrong property name.
Replaces the property name in the submission details from 'goodStanding' to 'goodStandingInd'.

Fixes FSADT1-1035

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• New unit tests
• New integrated tests
• New component tests
• New end-to-end tests
• New user flow tests
• No new tests are required
• Manual tests (description below)

Checklist

• I have read the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have already been accepted and merged

Further comments

---

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

[github-actions]

Current changelog

Bug Fixes

• display the Unknown standing notification (52016a1)
• replace goodStanding with goodStandingInd (f57a5f4)

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[sonarcloud]

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

14.3% Coverage
0.0% Duplication

[github-actions]

Frontend unit Test Coverage

Coverage after merging fix/FSADT1-1035 into main will be

55.97%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	48.39%	50%	0%	68.42%	108, 36, 39–40, 44, 52–53, 62
directivesMap.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	85%	60%	83.33%	95.83%	33–35, 50, 55
MainHeaderComponent.vue	79.69%	76.56%	58.33%	88.46%	100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
src/components/forms
AutoCompleteInputComponent.vue	75.38%	58.54%	80.95%	83.82%	110–111, 127, 132–133, 201, 46, 59, 61, 61, 61, 61, 61–63, 65, 65, 65–67, 77, 80, 80, 80, 80, 80, 82, 84
DropdownInputComponent.vue	89.11%	83.87%	83.33%	94.23%	111, 136, 152, 67, 81, 81, 81–82
MultiselectInputComponent.vue	91.49%	87.50%	85.71%	95.92%	100, 109, 122, 80, 89
RadioInputComponent.vue	88.46%	91.67%	75%	92.86%	38, 43, 82
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	86.49%	77.27%	84.62%	92.31%	122–123, 130, 55, 84, 89–90, 98
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	81.32%	75.28%	75%	86.18%	137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 450, 460, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	1.22%	0%	0%	2.73%	104–105, 107, 107, 107, 111–112, 114–115, 115, 115, 115, 117, 124, 131, 140–141, 141, 141, 141, 143, 145, 147, 151, 153–154, 154, 154–155, 155, 155, 155, 157, 159, 161, 164, 168–169, 169, 169, 169, 171, 173, 175, 179–180, 180, 180, 183, 185–186, 186–187, 187, 189, 19, 192, 194–196, 196, 196, 196, 196–198, 206, 208–209, 212, 214, 219–220, 220, 220–225, 225, 225–227, 230, 234–235, 235, 235–236, 247, 247, 247, 254, 254, 254–255, 255, 255–256, 256, 268, 268, 268, 270, 270, 270, 274, 274, 274, 28, 285, 285, 285–286, 286, 292, 292, 292, 294, 294, 294–295, 295, 295, 297, 297, 304, 304, 304, 312, 312, 312–313, 313, 313, 317, 317, 317, 333, 333, 333–334, 334, 334, 34, 345, 345, 345, 348, 348, 348–349, 349, 349, 35, 353, 353, 355, 355, 355, 37, 40, 42, 42, 42, 46, 46, 46, 49–51, 53–54, 57, 61–63, 66–68, 72, 76, 76, 76, 76, 76, 76–77, 82, 84, 87–88, 88, 88, 88, 88–89, 92, 95
ContactGroupComponent.vue	67.18%	83.33%	46.67%	64.15%	100, 114, 120, 137, 145, 154, 161, 170, 177, 185, 193, 201, 215, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91, 99, 99, 99
ErrorNotificationGroupingComponent.vue	74.67%	62.86%	57.14%	90.91%	110, 117, 117, 117, 121, 129, 129, 138, 150, 175, 175, 58, 63, 81, 90, 98
src/composables
useFetch.ts	87.69%	68.42%	100%	95.12%	117, 121, 130, 17, 51, 62, 66, 88
useFocus.ts	46.30%	26.67%	50%	55.17%	28, 30–32, 44, 50, 53, 53, 53, 55–57, 63, 63, 63, 66–67, 70, 85, 85, 85, 92, 95, 98
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	21.43%	13.04%	50%	22.22%	10, 17–18, 18, 18–19, 19, 19–21, 21, 21–22, 24, 27, 27, 27–28, 35–36, 36, 36–37, 43–45, 45, 45–48, 5, 5–7, 7, 7–8, 8, 8–9
DataConversors.ts	75.61%	79.17%	50%	73.33%	33, 38, 38, 38, 38, 38–39, 4, 41
ForestClientUserSession.ts	22.73%	8%	27.27%	28.85%	110–114, 114,

[github-actions]

Frontend component Test Coverage

Coverage after merging fix/FSADT1-1035 into main will be

92.91%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	100%	100%	100%	100%
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	100%	100%	100%	100%
UserProfileComponent.vue	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	92.74%	91.43%	85.71%	95.59%	201, 40, 46, 67, 80, 82
DropdownInputComponent.vue	90.63%	88.46%	83.33%	94.23%	111, 136, 152, 81, 81–82
MultiselectInputComponent.vue	90.11%	80.95%	85.71%	95.92%	100, 109, 122, 41, 47, 89
RadioInputComponent.vue	100%	100%	100%	100%
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	88.73%	78.95%	84.62%	94.87%	122–123, 130, 148, 55, 98
src/components/forms/DateInputComponent
DateInputPart.vue	100%	100%	100%	100%
common.ts	100%	100%	100%	100%
index.vue	100%	100%	100%	100%
src/components/grouping
AddressGroupComponent.vue	89.67%	89.89%	90.70%	89.09%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 274, 317, 355
ContactGroupComponent.vue	91.41%	95.56%	90%	88.68%	100, 137, 209, 215, 84, 91, 99, 99
ErrorNotificationGroupingComponent.vue	100%	100%	100%	100%
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	100%	100%	100%	100%
FormBCSCPage.vue	100%	100%	100%	100%
FormBCeIDPage.vue	100%	100%	100%	100%
FormSubmittedPage.vue	100%	100%	100%	100%
LandingPage.vue	100%	100%	100%	100%
NotFoundPage.vue	100%	100%	100%	100%
SubmissionListPage.vue	100%	100%	100%	100%
SubmissionReviewPage.vue	100%	100%	100%	100%
UserLoadingPage.vue	100%	100%	100%	100%
src/pages/bceidform
AddressWizardStep.vue	100%	100%	100%	100%
BusinessInformationWizardStep.vue	100%	100%	100%	100%
ContactWizardStep.vue	100%	100%	100%	100%
ReviewWizardStep.vue	100%	100%	100%	100%
src/services
ForestClientService.ts	100%	100%	100%	100%

[github-actions]

Frontend e2e Test Coverage

Coverage after merging fix/FSADT1-1035 into main will be

72.68%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	83.87%	75%	50%	100%	62
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	47.58%	50%	8.33%	53.85%	100, 107, 122, 134, 141, 150, 173, 173–174, 174–175, 175–176, 176, 185, 185, 185, 197, 197, 197, 201, 217, 217, 217, 230, 249, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
UserProfileComponent.vue	30%	0%	0%	42.86%	11–12, 15, 17, 17, 17, 17, 19, 21, 23, 4
src/components/forms
AutoCompleteInputComponent.vue	93.55%	94.29%	85.71%	95.59%	201, 46, 67, 80, 82
DropdownInputComponent.vue	96.88%	96.15%	94.44%	98.08%	111, 136
MultiselectInputComponent.vue	90.11%	80.95%	85.71%	95.92%	100, 109, 122, 41, 47, 89
RadioInputComponent.vue	90%	80%	83.33%	96.43%	38, 48, 84
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	92.96%	84.21%	92.31%	97.44%	122, 130, 148, 55
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	83.86%	74.29%	93.75%	86.18%	108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	89.67%	89.89%	90.70%	89.09%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 274, 317, 355
ContactGroupComponent.vue	98.44%	100%	100%	96.23%	84, 91
ErrorNotificationGroupingComponent.vue	38.03%	12.90%	57.14%	57.58%	110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 164, 175, 175, 175, 175, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 98, 98
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	25%	100%	100%	25%	11–12, 2
FormBCSCPage.vue	83.41%	66.67%	71.88%	91.97%	120–121, 134, 204, 264, 266, 275, 290–292, 315, 315, 315, 317–318, 323, 364, 455, 477, 49–51, 513, 513, 513, 62, 79
FormBCeIDPage.vue	56.17%	49.35%	33.33%	66.40%	110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 279, 279–284, 298, 298–299, 304, 304–305, 305–306, 306, 311, 317–318, 320, 320–322, 327–328, 337, 340–344, 354, 354, 356–358, 430, 460, 460, 460, 477, 477, 477, 525, 528, 528, 528, 547, 68–70, 89, 93–94, 96, 99
FormSubmittedPage.vue	61.11%	25%	0%	83.33%	12, 30, 32, 32, 32
LandingPage.vue	75%	42.86%	100%	92.31%	18, 18–19, 48, 58
SubmissionListPage.vue	8.05%	0%	0%	12.73%	103–105, 137, 153, 153, 178, 178, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
SubmissionReviewPage.vue	19.92%	0%	0%	40.17%	101, 103–105, 114, 114–115, 115, 120–121, 121–124, 128, 128, 142, 148–151, 151, 151–152, 154, 157, 160–161, 161–163, 166–167, 167–168, 170–171, 171–172, 175–176, 176–177, 177, 177–178, 181–182, 182, 182, 182, 182, 184, 186, 188, 190, 216, 216, 221, 221, 233, 233, 233, 233, 245, 245, 245, 245, 245, 268, 268, 268, 268, 268, 277, 277, 286, 32, 35–36, 384, 384, 39, 418, 418, 454, 454, 454–455, 455, 455, 459, 459,