Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Lab Controller support #235

Conversation

StykMartin
Copy link
Contributor

@StykMartin StykMartin commented Oct 28, 2024

This pull request introduces support for both Python 2 and Python 3, ensuring a smoother transition for RHEL 7 systems without impacting current production workflows. Given the high volume of lab controllers typically employed per Beaker deployment, maintaining compatibility with both Python versions is essential to minimize disruption for service owners during this migration.

By enabling dual-version support, we’re better positioned to streamline operations and provide a more flexible path forward for transitioning lab environments to Python 3, while sustaining stability and reliability in ongoing production environments 🚀

@StykMartin StykMartin force-pushed the wip/mstyk/lab-controller-python-six branch 5 times, most recently from 33474d2 to a424406 Compare October 28, 2024 18:35
@StykMartin StykMartin force-pushed the wip/mstyk/lab-controller-python-six branch 15 times, most recently from 2a346f5 to b92810c Compare October 28, 2024 20:10
Copy link
Collaborator

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks @StykMartin !

@StykMartin StykMartin force-pushed the wip/mstyk/lab-controller-python-six branch 4 times, most recently from 2eadae1 to d794489 Compare October 28, 2024 21:49
@beaker-project beaker-project deleted a comment from packit-as-a-service bot Oct 28, 2024
@beaker-project beaker-project deleted a comment from packit-as-a-service bot Oct 28, 2024
@beaker-project beaker-project deleted a comment from packit-as-a-service bot Oct 28, 2024
Signed-off-by: Martin Styk <[email protected]>
@StykMartin
Copy link
Contributor Author

@JohnVillalovos PTAL
This should give us a solid base for the Python 3 patch.

Copy link
Collaborator

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin!

This looks good to me. Great work and glad to see this happening 👍

@StykMartin StykMartin merged commit 185db0c into beaker-project:python-3 Oct 29, 2024
17 checks passed
@StykMartin StykMartin deleted the wip/mstyk/lab-controller-python-six branch October 29, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants