Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php merged versions #35

Merged
merged 29 commits into from
Nov 10, 2023
Merged

Php merged versions #35

merged 29 commits into from
Nov 10, 2023

Conversation

srobotta
Copy link
Collaborator

This pull request contains:

  • new vendor structure so that php < 8.1 and 8.1 onwards are supported
  • fix for the comments, allow atto, tiny and plain text area
  • adjust ci jobs so that all supported platforms are tested
  • exclude vendor dir from php checks
  • fix various errors and warnings that were reported from the ci

srobotta and others added 29 commits November 3, 2023 10:16
@srobotta
remove all php8.x from ci
90c6ec1
@srobotta
fix errors and warnings from ci
5fc34be
@srobotta
Fix error when creating new category without criteria
384672b
@srobotta
Fix initializing category header strings and code formating
dea5f64
@srobotta
Fix some coding errors in the language test and adjust formatting
3fbc36c
@srobotta
cosmetic changes
eb14473
@srobotta
ci: add Moodle 4.[1-3] with php 8.0
c608aa7
@srobotta
Update vendor libs and fix PHP8 warnings
55365da
@srobotta
fix PHP8.x warning
6b1ca9c
@srobotta
Fix warning: dynamic setting of property
9933471
@srobotta
Fix warning: dynamic setting of property
30013f3
@srobotta
Adapting changes to update of vendor lib
1a72f90
@srobotta
make the code checker happy
d604fdd
@srobotta
make the code checker happy
69cb6a1
@lucaboesch
Exclude classes/vendor files from Codechecker.
8d73bdc
@lucaboesch
Exclude classes/vendor files from Codechecker.
fd3b1c2
@lucaboesch
Amend mustache templates.
d7a532e
@lucaboesch
Amended moodle-plugin-ci.yml.
6428c60
@lucaboesch
Passing Mustache on Moodle Plugin CI.
7ccad83
@lucaboesch
Adhere to Moodle coding style.
586a62a
@srobotta
Chane settings in ci workflow to exclude vendor dir from checks
902d876
@srobotta
more fixes for the ci
270a623
@srobotta
Merge remote-tracking branch 'luca/php74_safe' into php81_update
98a6aed
@srobotta
Include vendor for PHP7x,8.0,<8.1.14 and PHP >= 8.1.14.
d945e63 
There's a switch that includes either one of the vendor
dir, depending on the PHP version running at the system. The reason
is that the Yaml library would not work correctly with newer PHP
versions. And update of the Yaml library dropped support for PHP < 8.1
but Moodle still supports it. That made the two versions necessary.
@srobotta
remove obsolete Grundfile.js
24c291b
@srobotta
add older supported PHP versions for Moodle 4.1 ci run
daabf0a
@srobotta
make detail rating comment fields work with all editors
2310b3e 
In the detail ratings the student and private comments
could be edited with atto and tiny. However, when clicking
one of the rating tags (--, -, +, ++) the atto only was filled
with the text block. This has been changed to work with
tinyMCE as well. Furthermore, if the user set in his preferences
to use the plain text area, this didn't work at all.
@srobotta
exclude the vendor dir from any checks
84799d8
@srobotta
hard fix in vendor dir so that installation works in ci with php8.0
e01c6c8
@lucaboesch lucaboesch merged commit 1cd223f into bfh:main Nov 10, 2023
0 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srobotta @lucaboesch