Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php merged versions #35

Merged
merged 29 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
90c6ec1
remove all php8.x from ci
srobotta Nov 3, 2023
5fc34be
fix errors and warnings from ci
srobotta Nov 3, 2023
384672b
Fix error when creating new category without criteria
srobotta Nov 3, 2023
dea5f64
Fix initializing category header strings and code formating
srobotta Nov 3, 2023
3fbc36c
Fix some coding errors in the language test and adjust formatting
srobotta Nov 3, 2023
eb14473
cosmetic changes
srobotta Nov 3, 2023
c608aa7
ci: add Moodle 4.[1-3] with php 8.0
srobotta Nov 3, 2023
55365da
Update vendor libs and fix PHP8 warnings
srobotta Nov 3, 2023
6b1ca9c
fix PHP8.x warning
srobotta Nov 3, 2023
9933471
Fix warning: dynamic setting of property
srobotta Nov 3, 2023
30013f3
Fix warning: dynamic setting of property
srobotta Nov 3, 2023
1a72f90
Adapting changes to update of vendor lib
srobotta Nov 3, 2023
d604fdd
make the code checker happy
srobotta Nov 3, 2023
69cb6a1
make the code checker happy
srobotta Nov 3, 2023
8d73bdc
Exclude classes/vendor files from Codechecker.
lucaboesch Nov 3, 2023
fd3b1c2
Exclude classes/vendor files from Codechecker.
lucaboesch Nov 3, 2023
d7a532e
Amend mustache templates.
lucaboesch Nov 3, 2023
6428c60
Amended moodle-plugin-ci.yml.
lucaboesch Nov 3, 2023
7ccad83
Passing Mustache on Moodle Plugin CI.
lucaboesch Nov 3, 2023
586a62a
Adhere to Moodle coding style.
lucaboesch Nov 3, 2023
902d876
Chane settings in ci workflow to exclude vendor dir from checks
srobotta Nov 6, 2023
270a623
more fixes for the ci
srobotta Nov 6, 2023
98a6aed
Merge remote-tracking branch 'luca/php74_safe' into php81_update
srobotta Nov 6, 2023
d945e63
Include vendor for PHP7x,8.0,<8.1.14 and PHP >= 8.1.14.
srobotta Nov 7, 2023
24c291b
remove obsolete Grundfile.js
srobotta Nov 7, 2023
daabf0a
add older supported PHP versions for Moodle 4.1 ci run
srobotta Nov 7, 2023
2310b3e
make detail rating comment fields work with all editors
srobotta Nov 7, 2023
84799d8
exclude the vendor dir from any checks
srobotta Nov 8, 2023
e01c6c8
hard fix in vendor dir so that installation works in ci with php8.0
srobotta Nov 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
89 changes: 34 additions & 55 deletions .github/workflows/moodle-plugin-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

services:
postgres:
Expand All @@ -15,11 +15,14 @@ jobs:
ports:
- 5432:5432
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 3

mariadb:
image: mariadb:10.6
env:
MYSQL_USER: 'root'
MYSQL_ALLOW_EMPTY_PASSWORD: "true"
MYSQL_CHARACTER_SET_SERVER: "utf8mb4"
MYSQL_COLLATION_SERVER: "utf8mb4_unicode_ci"
ports:
- 3306:3306
options: --health-cmd="mysqladmin ping" --health-interval 10s --health-timeout 5s --health-retries 3
Expand All @@ -28,72 +31,48 @@ jobs:
fail-fast: false
matrix:
include:
- php: 8.2
moodle-branch: MOODLE_403_STABLE
database: pgsql
- php: 8.2
moodle-branch: MOODLE_403_STABLE
database: mariadb
- php: 8.1
moodle-branch: MOODLE_403_STABLE
database: pgsql
- php: 8.1
moodle-branch: MOODLE_403_STABLE
- php: 7.4
moodle-branch: MOODLE_401_STABLE
database: mariadb
- php: 8.0
moodle-branch: MOODLE_403_STABLE
- php: 7.4
moodle-branch: MOODLE_401_STABLE
database: pgsql
- php: 8.0
moodle-branch: MOODLE_403_STABLE
moodle-branch: MOODLE_401_STABLE
database: mariadb
- php: 8.2
moodle-branch: MOODLE_402_STABLE
- php: 8.0
moodle-branch: MOODLE_401_STABLE
database: pgsql
- php: 8.2
moodle-branch: MOODLE_402_STABLE
- php: 8.1
moodle-branch: MOODLE_401_STABLE
database: mariadb
- php: 8.1
moodle-branch: MOODLE_402_STABLE
moodle-branch: MOODLE_401_STABLE
database: pgsql
- php: 8.1
moodle-branch: MOODLE_402_STABLE
database: mariadb
- php: 8.0
moodle-branch: MOODLE_402_STABLE
database: pgsql
- php: 8.0
moodle-branch: MOODLE_402_STABLE
database: mariadb
- php: 8.1
moodle-branch: MOODLE_401_STABLE
moodle-branch: MOODLE_402_STABLE
database: pgsql
- php: 8.1
moodle-branch: MOODLE_401_STABLE
database: mariadb
- php: 8.0
moodle-branch: MOODLE_401_STABLE
database: pgsql
- php: 8.0
moodle-branch: MOODLE_401_STABLE
moodle-branch: MOODLE_403_STABLE
database: mariadb
- php: 7.4
moodle-branch: MOODLE_401_STABLE
- php: 8.1
moodle-branch: MOODLE_403_STABLE
database: pgsql
- php: 7.4
moodle-branch: MOODLE_401_STABLE
- php: 8.2
moodle-branch: MOODLE_402_STABLE
database: mariadb
- php: 8.0
moodle-branch: MOODLE_400_STABLE
- php: 8.2
moodle-branch: MOODLE_402_STABLE
database: pgsql
- php: 8.0
moodle-branch: MOODLE_400_STABLE
- php: 8.2
moodle-branch: MOODLE_403_STABLE
database: mariadb
- php: 7.4
moodle-branch: MOODLE_400_STABLE
- php: 8.2
moodle-branch: MOODLE_403_STABLE
database: pgsql
- php: 7.4
moodle-branch: MOODLE_400_STABLE
database: mariadb

steps:
- name: Check out repository code
Expand All @@ -111,7 +90,7 @@ jobs:

- name: Initialise moodle-plugin-ci
run: |
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^3
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
echo $(cd ci/bin; pwd) >> $GITHUB_PATH
echo $(cd ci/vendor/bin; pwd) >> $GITHUB_PATH
sudo locale-gen en_AU.UTF-8
Expand All @@ -123,9 +102,10 @@ jobs:
env:
DB: ${{ matrix.database }}
MOODLE_BRANCH: ${{ matrix.moodle-branch }}
IGNORE_PATHS: moodle/tests/fixtures,moodle/Sniffs
CODECHECKER_IGNORE_PATHS: classes/vendor
PHPDOCCHECKER_IGNORE_PATHS: classes/vendor
IGNORE_PATHS: 'moodle/tests/fixtures,moodle/Sniffs,classes/vendor'
PHPCS_IGNORE_PATHS: /^classes\/vendor/
PHPDOCCHECKER_IGNORE_PATHS: /^classes\/vendor/
MUSTACHE_IGNORE_NAMES: 'report.mustache,questionnaire.mustache'

- name: PHP Lint
if: ${{ always() }}
Expand All @@ -143,7 +123,7 @@ jobs:

- name: Moodle Code Checker
if: ${{ always() }}
run: moodle-plugin-ci codechecker --max-warnings 0 || true
run: moodle-plugin-ci phpcs --max-warnings 0 || true

- name: Moodle PHPDoc Checker
if: ${{ always() }}
Expand All @@ -158,8 +138,9 @@ jobs:
run: moodle-plugin-ci savepoints

- name: Mustache Lint
continue-on-error: true # This step will show errors but will not fail
if: ${{ always() }}
run: moodle-plugin-ci mustache || true
run: moodle-plugin-ci mustache

- name: Grunt
if: ${{ always() }}
Expand All @@ -172,5 +153,3 @@ jobs:
- name: Behat features
if: ${{ always() }}
run: moodle-plugin-ci behat --profile chrome


85 changes: 0 additions & 85 deletions Gruntfile.js

This file was deleted.

Loading
Loading