Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syngap to v1.2.1 #47894

Closed
wants to merge 8 commits into from
Closed

Update syngap to v1.2.1 #47894

wants to merge 8 commits into from

Conversation

yanyew
Copy link
Contributor

@yanyew yanyew commented May 15, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@yanyew
Copy link
Contributor Author

yanyew commented May 15, 2024

@martin-g This time the PR failed in another wired way...
Is it somethind wrong about the Azure? I saw the same situation in other PR like https://dev.azure.com/bioconda/bioconda-recipes/_build/results?buildId=58625&view=logs&jobId=eb1ca712-fec5-5d93-deb0-40983fe61f2f&j=eb1ca712-fec5-5d93-deb0-40983fe61f2f
image

@martin-g
Copy link
Contributor

This is a known issue with the Azure CI - #47856
All PRs are affected!
We have to wait until it is resolved by Microsoft.

@yanyew yanyew closed this Jun 12, 2024
@yanyew yanyew reopened this Jun 12, 2024
@yanyew
Copy link
Contributor Author

yanyew commented Jun 12, 2024

@martin-g Hello, this PR somehow worked. Can you review it? Thanks!

recipes/syngap/build.sh Outdated Show resolved Hide resolved
recipes/syngap/build.sh Outdated Show resolved Hide resolved
bulid:
- python >=3.10
#bulid:
# - python >=3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented out lines.

commands:
commands:
- df -h
- du -sch $CONDA_PREFIX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the debug

recipes/syngap/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@yanyew yanyew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mentioned modification suggestions have been completed

@yanyew yanyew closed this Jun 12, 2024
@yanyew yanyew reopened this Jun 12, 2024
@yanyew yanyew closed this Jun 12, 2024
@yanyew yanyew deleted the syngap branch June 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants