More gracefully deal with not-perfectly-integer inputs #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! Could a note be added to the change log? |
sfiligoi
force-pushed
the
fpsum_230913
branch
from
a22ebb5
to
85dd7dc
Compare
…entical for large counts. Plus other minor optimizations and comments
sfiligoi
force-pushed
the
fpsum_230913
branch
from
e15f959
to
4724fe2
Compare
|
Great, thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input data is supposed to be integer, but it is represented using fp64.
If the elements are not precisely integer, the previous logic would fail, possibly leading to data corruption.
The new version enforces the integer constraint.