Fix/animation gui #625
Merged
Fix/animation gui #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flova
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Seems good.
I would have added a method to the recorder that checks if the values have changed for a given pair of frame and working values. But you approach is also totally valid.
I requested changes because of the failing formatting checks and the present debug prints.
Flova
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discarding the unrecorded data is expected behavior when changing frames. I have added a warning that reminds the user to record changes that would be discarded.
Related issues
#624
Checklist