download: Remove i686 Linux link #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the goal for merging this, before 0.19.1 or before 0.20.0? |
|
I'd say before 0.19.1, so that everyone has a final chance to complain before the binaries are no longer produced and uploaded. |
Co-Authored-By: David A. Harding <[email protected]>
|
After discussion on IRC I'm fine with merging this as soon as possible. It serves as an advance warning, and given that no one really seems to care that these are going away we might as well stop building them for 0.20. |
laanwj
reviewed
Feb 6, 2020
| @@ -251,21 +249,16 @@ <h2 style="text-align: center">{{page.build_reproduction}}</h2> | |||
| <script type="text/javascript"> | |||
| var os = 'windows64'; | |||
| if (navigator.userAgent.indexOf('Mac') != -1) var os = 'mac' | |||
| else if (navigator.userAgent.indexOf('Linux') != -1) { | |||
| var os='linux32'; | |||
There was a problem hiding this comment.
I guess we don't need this check for ARM, as the detection assumes Linux is always x86?
There was a problem hiding this comment.
I think we assume that only x86 can run a browser 😬
|
Tested ACK fa73ac1 |
|
From the weekly meeting: Will merge momentarily. |
harding
added a commit
that referenced
this pull request
Feb 6, 2020
fa73ac1 download: Remove i686 Linux links (MarcoFalke) Pull request description: There is only one known user of the i686 linux binary, so it is planned to be removed from the build and quality assurance pipeline. The last user (or users) is encouraged to compile locally with `make check && ./test/functional/test_runner.py` to run the tests on their target system. Using clang, this is possible even on systems with 1 GB of ram. See bitcoin/bitcoin#17504 Prepare this website and remove the download link from it early. ACKs for top commit: harding: Tested ACK fa73ac1 Tree-SHA512: f904d00371d077bf2fb88e69bdde120db518926556a709bc438407a7a00b0572efa61798e48c58e90aeb6191ab2ce2d5846ee178c3a0b5c5f34023999a0cfb41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one known user of the i686 linux binary, so it is planned to be removed from the build and quality assurance pipeline. The last user (or users) is encouraged to compile locally with
make check && ./test/functional/test_runner.pyto run the tests on their target system. Using clang, this is possible even on systems with 1 GB of ram. See bitcoin/bitcoin#17504Prepare this website and remove the download link from it early.