-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings to Wallet
#615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Might as well start merging that stuff. My only requested change would be to indent the comments to the same indentation level as the type/method they document, the way it's typically done in Rust/Python/Kotlin/Swift.
I can do that, sounds like a plan- |
c74be6a
to
36527f5
Compare
Done. rebased too. ready for merge after ACK |
rebased again, ready for merge after ACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0329ddc.
Description
The UDL file supports docstring comments.
Adds docstrings to
Wallet
Supersedes #454
Notes to the reviewers
We can do a mega-PR, but this PR just takes a section of the UDL (separate PR's for each section).
Per 1.0.0 beta 5 https://docs.rs/bdk_wallet/latest/bdk_wallet/index.html
Notable, can be updated in this PR:
examples
in code commentspersist
or top-levelWallet
Follow up
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: