Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to Wallet #615

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

reez
Copy link
Collaborator

@reez reez commented Oct 31, 2024

Description

The UDL file supports docstring comments.

Adds docstrings to Wallet

Supersedes #454

Notes to the reviewers

We can do a mega-PR, but this PR just takes a section of the UDL (separate PR's for each section).

Per 1.0.0 beta 5 https://docs.rs/bdk_wallet/latest/bdk_wallet/index.html

Notable, can be updated in this PR:

  • Didn't include examples in code comments
  • Didn't add code comments for constructors or persist or top-level Wallet

Follow up

  • Add checklist item about adding docstrings (to PR template)
  • Add section to README about docstrings (per Thunder)
  • We probably want to standardize some minor formatting (that doesn't seem to effect output on Swift side though)
    • space/tabs/none
    • line breaks
    • alphabetize

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez marked this pull request as ready for review October 31, 2024 18:06
@reez reez changed the title (draft) Add docstrings Add docstrings to Wallet Oct 31, 2024
@reez reez requested a review from thunderbiscuit October 31, 2024 18:06
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Might as well start merging that stuff. My only requested change would be to indent the comments to the same indentation level as the type/method they document, the way it's typically done in Rust/Python/Kotlin/Swift.

@reez
Copy link
Collaborator Author

reez commented Nov 14, 2024

This looks good! Might as well start merging that stuff. My only requested change would be to indent the comments to the same indentation level as the type/method they document, the way it's typically done in Rust/Python/Kotlin/Swift.

I can do that, sounds like a plan-

@reez reez force-pushed the docstrings branch 2 times, most recently from c74be6a to 36527f5 Compare November 14, 2024 20:44
@reez
Copy link
Collaborator Author

reez commented Nov 14, 2024

This looks good! Might as well start merging that stuff. My only requested change would be to indent the comments to the same indentation level as the type/method they document, the way it's typically done in Rust/Python/Kotlin/Swift.

Done. rebased too. ready for merge after ACK

@reez
Copy link
Collaborator Author

reez commented Nov 14, 2024

This looks good! Might as well start merging that stuff. My only requested change would be to indent the comments to the same indentation level as the type/method they document, the way it's typically done in Rust/Python/Kotlin/Swift.

Done. rebased too. ready for merge after ACK

rebased again, ready for merge after ACK

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0329ddc.

@thunderbiscuit thunderbiscuit merged commit 0329ddc into bitcoindevkit:master Nov 15, 2024
25 checks passed
@reez reez deleted the docstrings branch November 15, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants