-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to Descriptor
+ DescriptorPublicKey
#625
Conversation
d2f1246
to
80ca720
Compare
DescriptorPublicKey
Descriptor
+ DescriptorPublicKey
Concept ACK Cool additions |
@@ -266,6 +266,10 @@ impl Descriptor { | |||
let key_map = &self.key_map; | |||
descriptor.to_string_with_secret(key_map) | |||
} | |||
|
|||
pub(crate) fn is_multipath(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, why are all of these access modifiers crate
level? Clearly has no effect on the bindings but seems like a scope definition that doesn't actually apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question/point-
Thanks! |
I get a failure because
will do that right now just cuz I would like this to pass even though that naming isn't exactly equivalent to the function we are wrapping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny comment on the identation of the docstrings, but otherwise this is good to go IMO.
2d23e03
to
b9a89ec
Compare
Updated docstrings indentation, rebased, ready to merge 👍 |
Sorry man I merged #629 before this one, so you'll have to rebase, but feel free to merge afterwards! |
Description
https://docs.rs/bdk_wallet/latest/bdk_wallet/descriptor/enum.DescriptorPublicKey.html#method.master_fingerprint
https://docs.rs/bdk_wallet/latest/bdk_wallet/descriptor/enum.DescriptorPublicKey.html#method.is_multipath
https://docs.rs/bdk_wallet/latest/bdk_wallet/descriptor/enum.Descriptor.html#method.is_multipath
https://docs.rs/bdk_wallet/latest/bdk_wallet/descriptor/enum.Descriptor.html#method.into_single_descriptors
Would love for this to get into our beta6
Notes to the reviewers
Use Cases:
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: