feat: expose Wallet::policies method #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reez
reviewed
Nov 15, 2024
bdk-ffi/src/types.rs
Outdated
|
|
||
| Multisig { | ||
| keys: Vec<PkOrF>, | ||
|
|
reez
reviewed
Nov 15, 2024
bdk-ffi/src/types.rs
Outdated
|
|
||
| Thresh { | ||
| items: Vec<Arc<Policy>>, | ||
|
|
reez
reviewed
Nov 15, 2024
bdk-ffi/src/types.rs
Outdated
| Complete { | ||
| condition: Condition, | ||
| }, | ||
|
|
reez
reviewed
Nov 15, 2024
bdk-ffi/src/types.rs
Outdated
| .map(|(index, conditions)| { | ||
| ( | ||
| index.iter().map(|e| e.to_owned() as u32).collect(), | ||
| conditions.into_iter().map(|e| e.into()).collect(), // Convert each `Condition` to `YourType` |
There was a problem hiding this comment.
nit: remove code comment potentially?
reez
reviewed
Nov 15, 2024
bdk-ffi/src/types.rs
Outdated
| RelativeTimelock { | ||
| value: u32, | ||
| }, | ||
|
|
reez
approved these changes
Nov 15, 2024
thunderbiscuit
force-pushed
the
add-policy-api
branch
from
6574022 to
5b74617
Compare
|
Thanks! Indeed I found a few places where newlines where missing and a few places where newlines where not applied systematically. Fixed all that now. |
This was referenced Nov 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know wtf is going on with this branch/PR and the naming but it's really not liking me pushing to it.