Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Disable all usages of usePasswordFiles if auth.enabled is unset #32253

Merged
merged 6 commits into from
Mar 4, 2025
Merged

[bitnami/redis] Disable all usages of usePasswordFiles if auth.enabled is unset #32253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8c6bd9
fix: disable all usages of auth.usePasswordFiles if auth.enabled is u…
holzgeist Mar 4, 2025
59d8867
chore: bump chart version
holzgeist Mar 4, 2025
aa65e46
Update CHANGELOG.md
bitnami-bot Mar 4, 2025
465a4a9
Fix metrics - statefulset.yaml
migruiz4 Mar 4, 2025
99f2389
Fix metrics - application.yaml
migruiz4 Mar 4, 2025
b7f145d
Fix metrics application.yaml
migruiz4 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bitnami/redis/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Changelog

## 20.11.1 (2025-03-04)

* [bitnami/redis] Disable all usages of usePasswordFiles if auth.enabled is unset ([#32253](https://github.com/bitnami/charts/pull/32253))

## 20.11.0 (2025-03-03)

* [bitnami/redis] feat: Add external access service for redis sentinel ([#32190](https://github.com/bitnami/charts/pull/32190))
* [bitnami/redis] feat: Add external access service for redis sentinel (#32190) ([0582ac3](https://github.com/bitnami/charts/commit/0582ac395c8aa9ef5e9d9df7772775397dd674b1)), closes [#32190](https://github.com/bitnami/charts/issues/32190)

## <small>20.10.1 (2025-03-03)</small>

Expand Down
2 changes: 1 addition & 1 deletion bitnami/redis/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ maintainers:
name: redis
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/redis
version: 20.11.0
version: 20.11.1
2 changes: 1 addition & 1 deletion bitnami/redis/templates/master/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ spec:
- /bin/bash
- -c
- |
{{- if and .Values.auth.enabled .Values.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
export REDIS_PASSWORD="$(< $REDIS_PASSWORD_FILE)"
{{- end }}
redis_exporter{{- range $key, $value := .Values.metrics.extraArgs }} --{{ $key }}={{ $value }}{{- end }}
Expand Down
8 changes: 4 additions & 4 deletions bitnami/redis/templates/replicas/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ spec:
mountPath: /opt/bitnami/scripts/start-scripts
- name: health
mountPath: /health
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
mountPath: /opt/bitnami/redis/secrets/
{{- end }}
Expand Down Expand Up @@ -308,7 +308,7 @@ spec:
- /bin/bash
- -c
- |
{{- if .Values.usePasswordFiles }}
Copy link

@littlelionking littlelionking Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be updated to .Values.auth.usePasswordFiles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I must have missed it while editing in the Github UI.

I have restored #32259 just to fix that

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please be consistent .Values.auth.usePasswordFiles or .Values.usePasswordFiles - see for more information: #32352

{{- if and .Values.auth.enabled .Values.usePasswordFiles }}
export REDIS_PASSWORD="$(< $REDIS_PASSWORD_FILE)"
{{- end }}
redis_exporter{{- range $key, $value := .Values.metrics.extraArgs }} --{{ $key }}={{ $value }}{{- end }}
Expand Down Expand Up @@ -388,7 +388,7 @@ spec:
- name: empty-dir
mountPath: /tmp
subPath: tmp-dir
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
mountPath: /secrets/
{{- end }}
Expand Down Expand Up @@ -483,7 +483,7 @@ spec:
configMap:
name: {{ printf "%s-health" (include "common.names.fullname" .) }}
defaultMode: 0755
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
{{ if .Values.auth.usePasswordFileFromSecret }}
secret:
Expand Down
10 changes: 5 additions & 5 deletions bitnami/redis/templates/sentinel/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ spec:
mountPath: /health
- name: sentinel-data
mountPath: /opt/bitnami/redis-sentinel/etc
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
mountPath: /opt/bitnami/redis/secrets/
{{- end }}
Expand Down Expand Up @@ -507,7 +507,7 @@ spec:
{{- end }}
- name: sentinel-data
mountPath: /opt/bitnami/redis-sentinel/etc
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
mountPath: /opt/bitnami/redis/secrets/
{{- end }}
Expand Down Expand Up @@ -542,7 +542,7 @@ spec:
- /bin/bash
- -c
- |
{{- if .Values.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
export REDIS_PASSWORD="$(< $REDIS_PASSWORD_FILE)"
{{- end }}
redis_exporter{{- range $key, $value := .Values.metrics.extraArgs }} --{{ $key }}={{ $value }}{{- end }}
Expand Down Expand Up @@ -622,7 +622,7 @@ spec:
- name: empty-dir
mountPath: /tmp
subPath: tmp-dir
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
mountPath: /secrets/
{{- end }}
Expand Down Expand Up @@ -742,7 +742,7 @@ spec:
name: {{ printf "%s-kubectl-scripts" (include "common.names.fullname" .) }}
defaultMode: 0755
{{- end }}
{{- if .Values.auth.usePasswordFiles }}
{{- if and .Values.auth.enabled .Values.auth.usePasswordFiles }}
- name: redis-password
{{ if .Values.auth.usePasswordFileFromSecret }}
secret:
Expand Down
Loading