[bitnami/redis] Disable all usages of usePasswordFiles if auth.enabled is unset #32253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzgeist
force-pushed
the
fix-use-password-only-if-auth-is-set-v2
branch
from
13e3020 to
1b06479
Compare
…nset Signed-off-by: Tobias Ollmann <[email protected]>
Signed-off-by: Tobias Ollmann <[email protected]>
holzgeist
force-pushed
the
fix-use-password-only-if-auth-is-set-v2
branch
from
1b06479 to
59d8867
Compare
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]>
Signed-off-by: Miguel Ruiz <[email protected]> Signed-off-by: Miguel Ruiz <[email protected]>
4 tasks
migruiz4
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thank you for your contribution @holzgeist!
Due to the similarity in the changes, and in order to avoid releasing two versions of the chart, I have implemented some changes from (#32259) into this PR.
dgomezleon
approved these changes
Mar 4, 2025
| @@ -308,7 +308,7 @@ spec: | |||
| - /bin/bash | |||
| - -c | |||
| - | | |||
| {{- if .Values.usePasswordFiles }} | |||
There was a problem hiding this comment.
This can also be updated to .Values.auth.usePasswordFiles
There was a problem hiding this comment.
My bad, I must have missed it while editing in the Github UI.
I have restored #32259 just to fix that
There was a problem hiding this comment.
please be consistent .Values.auth.usePasswordFiles or .Values.usePasswordFiles - see for more information: #32352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a followup of #32208 (also reported here #32218) to disable usage of usePasswordFiles not only in master, but also replicas and sentinel
Benefits
Deployments using replicas and sentinel don't crash with the error mentioned in #32218
Possible drawbacks
None that I'm aware
Applicable issues
Additional information
This is a pure copy&pase PR, I don't have the infrastructure to generate/test Helm Charts
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm