Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/redis] Fix usePasswordFile typo in metrics container #32259

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[bitnami/redis] Fix usePasswordFile typo in metrics container #32259

merged 5 commits into from
Mar 5, 2025

Conversation

migruiz4
Copy link
Member

@migruiz4 migruiz4 commented Mar 4, 2025

Description of the change

Fixes issue when usePasswordFile=true and metrics are enabled.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added redis verify Execute verification workflow for these changes bitnami labels Mar 4, 2025
@github-actions github-actions bot requested a review from gongomgra March 4, 2025 10:31
@bitnami-bot
Update CHANGELOG.md
40a23f7 
Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4
Copy link
Member Author

migruiz4 commented Mar 4, 2025

Superseeded by #32253

@migruiz4 migruiz4 closed this Mar 4, 2025
@github-actions github-actions bot added the solved label Mar 4, 2025
@migruiz4 migruiz4 mentioned this pull request Mar 4, 2025
Merged
4 tasks
@migruiz4 migruiz4 reopened this Mar 5, 2025
@github-actions github-actions bot removed the solved label Mar 5, 2025
@github-actions github-actions bot requested a review from dgomezleon March 5, 2025 07:31
migruiz4 added 2 commits March 5, 2025 08:32
@migruiz4
Merge branch 'main' into redis-pf-metrics
aafc3fd 
Signed-off-by: Miguel Ruiz <[email protected]>
@migruiz4
Bump version
b579f91 
Signed-off-by: Miguel Ruiz <[email protected]>

Signed-off-by: Miguel Ruiz <[email protected]>
@fmulero fmulero linked an issue Mar 5, 2025 that may be closed by this pull request
Incorrect values file reference #32220
Closed
@bitnami-bot
Update CHANGELOG.md
129777e 
Signed-off-by: Bitnami Containers <[email protected]>
@fmulero fmulero removed a link to an issue Mar 5, 2025
Incorrect values file reference #32220
Closed
fmulero
fmulero approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migruiz4 migruiz4 merged commit a2cb202 into main Mar 5, 2025
12 checks passed
@migruiz4 migruiz4 deleted the redis-pf-metrics branch March 5, 2025 08:07
@github-actions github-actions bot added the solved label Mar 5, 2025
@wrenix wrenix mentioned this pull request Mar 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

@gongomgra gongomgra Awaiting requested review from gongomgra

@dgomezleon dgomezleon Awaiting requested review from dgomezleon

Assignees

@gongomgra gongomgra

@dgomezleon dgomezleon

Labels
bitnami redis solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@migruiz4 @fmulero @gongomgra @dgomezleon @bitnami-bot