Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11162] Assign To Collections Permission Update #11367

Merged
merged 69 commits into from
Feb 4, 2025

add disable check for owners without edit/manage access inside PM

df453f2
Select commit
Loading
Failed to load commit list.
Merged

[PM-11162] Assign To Collections Permission Update #11367

add disable check for owners without edit/manage access inside PM
df453f2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2025 in 0s

35.28% (+0.03%) compared to a04dd7a

View this Pull Request on Codecov

35.28% (+0.03%) compared to a04dd7a

Details

Codecov Report

Attention: Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.28%. Comparing base (a04dd7a) to head (df453f2).
Report is 21 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ult/src/components/assign-collections.component.ts 0.00% 6 Missing ⚠️
...lt/components/vault-items/vault-items.component.ts 0.00% 4 Missing ⚠️
...nts/item-details/item-details-section.component.ts 71.42% 3 Missing and 1 partial ⚠️
libs/common/src/vault/models/view/cipher.view.ts 0.00% 3 Missing ⚠️
apps/cli/src/commands/edit.command.ts 0.00% 2 Missing ⚠️
...mponents/vault-items/vault-cipher-row.component.ts 0.00% 2 Missing ⚠️
...2/item-more-options/item-more-options.component.ts 0.00% 1 Missing ⚠️
apps/cli/src/models/response.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11367      +/-   ##
==========================================
+ Coverage   35.24%   35.28%   +0.03%     
==========================================
  Files        2997     2997              
  Lines       90886    90896      +10     
  Branches    16973    16974       +1     
==========================================
+ Hits        32034    32073      +39     
+ Misses      56364    56335      -29     
  Partials     2488     2488

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov