Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12399] Show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher #11913

Merged
merged 3 commits into from
Nov 13, 2024
+89 −4

update tests

6dc73b8
Select commit
Loading
Failed to load commit list.
Merged

[PM-12399] Show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher #11913

update tests
6dc73b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 0s

33.47% (-0.01%) compared to 204eb31

View this Pull Request on Codecov

33.47% (-0.01%) compared to 204eb31

Details

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (204eb31) to head (6dc73b8).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ult/popup/services/vault-popup-autofill.service.ts 25.00% 14 Missing and 1 partial ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11913      +/-   ##
==========================================
- Coverage   33.47%   33.47%   -0.01%     
==========================================
  Files        2844     2844              
  Lines       89022    89044      +22     
  Branches    16980    16987       +7     
==========================================
+ Hits        29803    29805       +2     
- Misses      56876    56894      +18     
- Partials     2343     2345       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov