Auth/PM-8113 - 2FA Components UI Refresh #12087
Draft
+1,097
−1,228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of UnauthenticatedExtensionUIRefresh flag
…ed import is used a dialog.
…s-ui-refresh + merge conflict fixes
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12087 +/- ##
==========================================
+ Coverage 34.13% 34.22% +0.09%
==========================================
Files 2937 2949 +12
Lines 90383 90275 -108
Branches 16973 16939 -34
==========================================
+ Hits 30848 30896 +48
+ Misses 57080 56914 -166
- Partials 2455 2465 +10 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
…ead of libs/angular/src/auth
…en top level page component and child components
…tor-auth and move all logic into single component - WIP
…s-ui-refresh + merge confliction resolution
…nt imports on other clients.
…ulLoginNavigate (3) after successful login we always loginEmailService.clearValues()
…tion and each clients implementation of the duo2faResultListener
…for launchDuoFrameless
…s-ui-refresh + merge conflict fixes
…s-ui-refresh + merge conflict resolutions
…heckboxModule import
…ss in destroy context as you can't use takeUntilDestroyed in ngOnInit without it.
…s-ui-refresh + merge conflig fix in web index.ts
… webauthn new tab check as webauthn seems to work without it
…nt service for new tab logic
…actorAuthWebAuthnComponent
…s-ui-refresh + merge conflict fixes
…conflict resolutions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8113
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes