Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/PM-8113 - 2FA Components UI Refresh #12087

Draft
wants to merge 83 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
0959069
PM-8113 - Deprecate TwoFactorComponentRefactor feature flag in favor โ€ฆ
JaredSnider-Bitwarden Nov 19, 2024
4d06957
PM-8113 - Rename all existing 2FA components as V1.
JaredSnider-Bitwarden Nov 21, 2024
411385e
PM-8113 - TwoFactorAuthComp - Add comment explaining that tagged unusโ€ฆ
JaredSnider-Bitwarden Nov 21, 2024
1709ffd
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Nov 22, 2024
2ac5348
PM-8113 - 2FA Auth Comp - deprecate captcha
JaredSnider-Bitwarden Dec 3, 2024
fd8923a
PM-8113 - LoginStrategySvc - add todo for deprecation of captcha respโ€ฆ
JaredSnider-Bitwarden Dec 3, 2024
21af124
PM-8113 - TwoFactorAuth tests - remove captcha
JaredSnider-Bitwarden Dec 3, 2024
84d817e
PM-8113 - TwoFactorAuthComp HTML - remove captcha
JaredSnider-Bitwarden Dec 3, 2024
d49b1b6
PM-8113 - Web Two Factor Auth - update deps
JaredSnider-Bitwarden Dec 3, 2024
bca8fae
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Dec 3, 2024
430cff6
PM-8113 - Move all new two-factor-auth components into libs/auth instโ€ฆ
JaredSnider-Bitwarden Dec 3, 2024
7167861
PM-8113 - Add new child-components folder to help differentiate betweโ€ฆ
JaredSnider-Bitwarden Dec 3, 2024
6a97b0c
PM-8113 - Add todo for browser TwoFactorAuthEmailComponent
JaredSnider-Bitwarden Dec 4, 2024
fd9b0cf
PM-8113 - TwoFactorAuth - progress on consolidation
JaredSnider-Bitwarden Dec 4, 2024
f838694
PM-8113 - TwoFactorAuth - add TODO to ensure I don't miss web on succโ€ฆ
JaredSnider-Bitwarden Dec 5, 2024
0b3cd49
PM-8113 - TwoFactorAuth - Deprecate browser implementation of two-facโ€ฆ
JaredSnider-Bitwarden Dec 5, 2024
c9ced8a
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Dec 9, 2024
df42717
PM-8113 - Bring across 2FA session timeout to new 2FA orchestrator comp
JaredSnider-Bitwarden Dec 9, 2024
c28c8cb
PM-8113 - Export TwoFactorAuth from libs/auth
JaredSnider-Bitwarden Dec 9, 2024
8d8f595
PM-8113 - Fix 2FA Auth Comp tests by adding new service deps.
JaredSnider-Bitwarden Dec 9, 2024
e1f558c
PM-8113 - Fix TwoFactorAuthExpiredComp imports + TwoFactorAuthComponeโ€ฆ
JaredSnider-Bitwarden Dec 9, 2024
5989239
PM-8113 - 2FA Auth Comp - Progress on removing onSuccessfulLogin callโ€ฆ
JaredSnider-Bitwarden Dec 9, 2024
0caf9d8
PM-8113 - 2FA Auth - update deps to private as inheritance will no loโ€ฆ
JaredSnider-Bitwarden Dec 9, 2024
15bff43
PM-8113 - TwoFactorAuthComp - Refactor init a bit.
JaredSnider-Bitwarden Dec 9, 2024
e70c126
PM-8113 - TwoFactorAuthComp - More naming refactors
JaredSnider-Bitwarden Dec 9, 2024
3b154fa
PM-8113 - TwoFactorAuth - (1) more refactoring (2) removed onSuccessโ€ฆ
JaredSnider-Bitwarden Dec 9, 2024
d9c05e8
PM-8113 - TwoFactorAuthComp Tests - clean up tests for removed callbaโ€ฆ
JaredSnider-Bitwarden Dec 10, 2024
9bee399
PM-8113 - TwoFactorAuthComponent - refactor default success route hanโ€ฆ
JaredSnider-Bitwarden Dec 10, 2024
a5cf61b
PM-8113 - TwoFactorAuthComp - More refactoring
JaredSnider-Bitwarden Dec 10, 2024
3aa96b8
PM-8113 - TwoFactorAuthComp - more refactors
JaredSnider-Bitwarden Dec 10, 2024
e846d09
PM-8113 - TwoFactorAuth - Remove unused service dep
JaredSnider-Bitwarden Dec 10, 2024
7235b37
PM-8113 - TwoFactorAuthComp - Refactor out unused button action text โ€ฆ
JaredSnider-Bitwarden Dec 10, 2024
4a60ae2
PM-8113 - TwoFactorAuthComponent - Add type for providerData
JaredSnider-Bitwarden Dec 10, 2024
055276b
PM-8113 - TwoFactorAuthComponent - Add todo
JaredSnider-Bitwarden Dec 11, 2024
c0fa016
PM-8113 - TwoFactorAuthComponent - Add client type
JaredSnider-Bitwarden Dec 12, 2024
0fa92b7
PM-8113 - TwoFactorAuth - implement browser specific SSO + 2FA logic
JaredSnider-Bitwarden Dec 12, 2024
f28242a
PM-8113 - TwoFactorService Abstraction - refactor to use proper functโ€ฆ
JaredSnider-Bitwarden Dec 12, 2024
30df063
PM-8113 - Refactor 2FA Guard logic out of ngOnInit and into own testeโ€ฆ
JaredSnider-Bitwarden Dec 12, 2024
831328c
PM-8113 - TwoFactorAuthComponent - WIP on webauthn init.
JaredSnider-Bitwarden Dec 14, 2024
42719e4
PM-8113 - TwoFactorAuthComponent - pull webauthn fallback response haโ€ฆ
JaredSnider-Bitwarden Dec 14, 2024
3b524fc
PM-8113 - TwoFactorAuthComponent - move linux popup width extension lโ€ฆ
JaredSnider-Bitwarden Dec 14, 2024
2d1bb31
PM-8113 - WebTwoFactorAuthComponentService - add explicit override foโ€ฆ
JaredSnider-Bitwarden Dec 15, 2024
bbdb0c2
PM-8113 - Implement new TwoFactorAuthComponentService .openPopoutIfApโ€ฆ
JaredSnider-Bitwarden Dec 15, 2024
8fa330f
PM-8113 - TwoFactorAuthComponent - misc cleanup
JaredSnider-Bitwarden Dec 15, 2024
12b5da1
PM-8113 - TwoFactorAuthComponent - more clean up
JaredSnider-Bitwarden Dec 15, 2024
e19f3ea
PM-8113 - TwoFactorAuthComponent - WIP on removing TDE callbacks
JaredSnider-Bitwarden Dec 15, 2024
38dc309
PM-8113 - TwoFactorAuthComponent - finish refactoring out all callbacks
JaredSnider-Bitwarden Dec 15, 2024
a1f82e5
PM-8113 - TwoFactorAuthComponent - remove now unused method
JaredSnider-Bitwarden Dec 15, 2024
8f19645
PM-8113 - TwoFactorAuthComponent - refactor routes.
JaredSnider-Bitwarden Dec 15, 2024
ace5f3b
PM-8113 - TwoFactorAuthComponent - add TODO
JaredSnider-Bitwarden Dec 15, 2024
71fd85c
PM-8113 - TwoFactorAuthComp - isTrustedDeviceEncEnabled - add undefinโ€ฆ
JaredSnider-Bitwarden Dec 15, 2024
112f9d4
PM-8113 - TwoFactorAuthComponent tests - updated to pass
JaredSnider-Bitwarden Dec 15, 2024
3eef259
PM-8113 - (1) Consolidate TwoFactorAuthEmail component into new serviโ€ฆ
JaredSnider-Bitwarden Dec 16, 2024
d1d438b
PM-8113 - Refactor libs/auth/2fa into barrel files.
JaredSnider-Bitwarden Dec 16, 2024
9f8696f
PM-8113 - Move TwoFactorAuthEmail content to own folder.
JaredSnider-Bitwarden Dec 16, 2024
7e0c113
PM-8113 - Move 2FA Duo to own comp folder.
JaredSnider-Bitwarden Dec 16, 2024
f7a7938
PM-8113 - ExtensionTwoFactorAuthEmailComponentService - Add comment
JaredSnider-Bitwarden Dec 16, 2024
1b66049
PM-8113 - TwoFactorAuthEmailComponentService - add docs
JaredSnider-Bitwarden Dec 18, 2024
9905c6f
PM-8113 - TwoFactorAuthDuoComponentService - define top level abstraโ€ฆ
JaredSnider-Bitwarden Dec 18, 2024
5e9249a
PM-8113 - TwoFactorAuthDuoCompService - add client specific handling โ€ฆ
JaredSnider-Bitwarden Dec 19, 2024
4ddc319
PM-8113 - Delete no longer used client specific two factor auth duo cโ€ฆ
JaredSnider-Bitwarden Dec 19, 2024
5c49f6e
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Dec 19, 2024
f9737df
PM-8113 - Register TwoFactorAuthDuoComponentService implementation inโ€ฆ
JaredSnider-Bitwarden Dec 20, 2024
8dd4c51
PM-8113 - TwoFactorAuthComp - add destroy ref to fix warnings.
JaredSnider-Bitwarden Dec 20, 2024
09f87c8
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Jan 6, 2025
8e23dcf
PM-8113 - Remove accidentally checked in dev change
JaredSnider-Bitwarden Jan 6, 2025
ecb34eb
PM-8113 - TwoFactorAuthComp - (1) Add loading state (2) Add missing โ€ฆ
JaredSnider-Bitwarden Jan 6, 2025
0416c54
Merge branch 'main' into auth/pm-8113/2fa-comps-ui-refresh
JaredSnider-Bitwarden Jan 6, 2025
2c620ea
PM-8113 - TwoFactorAuthDuoComponent - update takeUntilDestroyed to paโ€ฆ
JaredSnider-Bitwarden Jan 7, 2025
b933462
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Jan 9, 2025
d5391ba
PM-8113 - TwoFactorAuthWebAuthnComponent - remove no longer necessaryโ€ฆ
JaredSnider-Bitwarden Jan 9, 2025
ee8592c
PM-8113 - TwoFactorAuthWebAuthnComp - refactor names and add todo
JaredSnider-Bitwarden Jan 9, 2025
206b23f
PM-8113 - (1) Move WebAuthn 2FA comp to own folder (2) build out clieโ€ฆ
JaredSnider-Bitwarden Jan 10, 2025
b3befbd
PM-8113 - Register TwoFactorAuthWebAuthnComponentServices
JaredSnider-Bitwarden Jan 10, 2025
78a09b1
PM-8113 - Tweak TwoFactorAuthWebAuthnComponentService and add to TwoFโ€ฆ
JaredSnider-Bitwarden Jan 10, 2025
7c53135
PM-8113 - WebTwoFactorAuthDuoComponentService - fix type issue
JaredSnider-Bitwarden Jan 10, 2025
0971088
PM-8113 - ExtensionTwoFactorAuthDuoComponentService - attempt to fix โ€ฆ
JaredSnider-Bitwarden Jan 10, 2025
30aabc3
PM-8113 - Remove ts-strict-ignore
JaredSnider-Bitwarden Jan 10, 2025
13d0d0d
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-compโ€ฆ
JaredSnider-Bitwarden Jan 10, 2025
2dc94df
PM-8113 - TwoFactorAuthWebAuthnComponent - satisfy strict typescript โ€ฆ
JaredSnider-Bitwarden Jan 13, 2025
22a82be
PM-8113 - TwoFactorAuthComponent - some progress on strict TS conversion
JaredSnider-Bitwarden Jan 13, 2025
53bb473
Merge branch 'main' into auth/pm-8113/2fa-comps-ui-refresh and merge โ€ฆ
JaredSnider-Bitwarden Jan 14, 2025
282d7e4
PM-8113 - TwoFactorAuthComp - fixed all strict typescript issues.
JaredSnider-Bitwarden Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 0 additions & 122 deletions apps/browser/src/auth/popup/two-factor-auth-duo.component.ts

This file was deleted.

69 changes: 0 additions & 69 deletions apps/browser/src/auth/popup/two-factor-auth-email.component.ts

This file was deleted.

170 changes: 0 additions & 170 deletions apps/browser/src/auth/popup/two-factor-auth.component.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ActivatedRoute, Router } from "@angular/router";
import { Subject, Subscription, firstValueFrom } from "rxjs";
import { filter, first, takeUntil } from "rxjs/operators";

import { TwoFactorComponent as BaseTwoFactorComponent } from "@bitwarden/angular/auth/components/two-factor.component";
import { TwoFactorComponentV1 as BaseTwoFactorComponent } from "@bitwarden/angular/auth/components/two-factor-v1.component";
import { WINDOW } from "@bitwarden/angular/services/injection-tokens";
import {
LoginStrategyServiceAbstraction,
Expand Down Expand Up @@ -37,9 +37,9 @@ import { closeTwoFactorAuthPopout } from "./utils/auth-popout-window";

@Component({
selector: "app-two-factor",
templateUrl: "two-factor.component.html",
templateUrl: "two-factor-v1.component.html",
})
export class TwoFactorComponent extends BaseTwoFactorComponent implements OnInit, OnDestroy {
export class TwoFactorComponentV1 extends BaseTwoFactorComponent implements OnInit, OnDestroy {
private destroy$ = new Subject<void>();
inPopout = BrowserPopupUtils.inPopout(window);

Expand Down
Loading
Loading